Bug 139453 - lyrics script interface needs more and better message passing
Summary: lyrics script interface needs more and better message passing
Status: RESOLVED INTENTIONAL
Alias: None
Product: amarok
Classification: Applications
Component: Tools/Script Manager (show other bugs)
Version: 1.4.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-31 23:23 UTC by Cyrus007
Modified: 2007-01-04 03:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cyrus007 2006-12-31 23:23:36 UTC
Version:           1.4.3 (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

Did look up bug no 135213.
This is a request for an enhancement to the message string passed to lyrics script. Right now it passes commands like configure/fetchLyrics/fetchLyricsByUrl with artist and title only. Need more like 'Album', 'Genre', 'Composer' etc - infact all the tags if possible. It would be better to send them by parameter=value pairs after the command to take care of empty values (right now e.g. title is send as first parameter if artist is not present).

Why do we want this: so that the scripts can fetch lyrics from alternate sites from many possible based on specific parameter values. Here is an example. I have a script called iTRANS Amarok Script @ http://www.kde-apps.org/content/show.php?content=50890 which displays scripts in non-romanised font. Well I want this to be called only when say the genre='Hindi....' and call lyrc for other genre. But why genre=..., because some sites have romanised version of the same lyrics too, which I want to be called when genre!='Hindi...'

I will work on it to see if I can come up with something.
Comment 1 Cyrus007 2007-01-04 03:28:43 UTC
Found a workaround for this using dcop call to get the tags of the currently playing song.
Comment 2 Alexandre Oliveira 2007-01-04 03:35:01 UTC
Since artist/title is enough for most of the scripts, I'll leave dcop as the official option for the exceptions.