Bug 139225 - konsole crashes after zooming text to really large size
Summary: konsole crashes after zooming text to really large size
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR crash
Target Milestone: ---
Assignee: Robert Knight
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-26 04:57 UTC by Yuriy Kozlov
Modified: 2007-05-08 01:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Backtrace (3.72 KB, text/plain)
2006-12-26 04:58 UTC, Yuriy Kozlov
Details
Backtrace (3.72 KB, text/plain)
2006-12-26 04:58 UTC, Yuriy Kozlov
Details
Patch to fix bug #139225, restricts maximum font size to that which will fit in the display. (2.06 KB, patch)
2006-12-26 18:45 UTC, Robert Knight
Details
Better patch to fix the crash. (743 bytes, patch)
2007-01-26 10:04 UTC, Robert Knight
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuriy Kozlov 2006-12-26 04:57:55 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

Originally reported here: https://launchpad.net/distros/ubuntu/+source/kdebase/+bug/53159

Enlarging the font in konsole so much that a letter is bigger than the window causes konsole to crash.

One shouldn't even be able to enlarge the font to such an unreasonable size.
Comment 1 Yuriy Kozlov 2006-12-26 04:58:33 UTC
Created attachment 19034 [details]
Backtrace
Comment 2 Yuriy Kozlov 2006-12-26 04:58:34 UTC
Created attachment 19035 [details]
Backtrace
Comment 3 Robert Knight 2006-12-26 18:45:40 UTC
Created attachment 19036 [details]
Patch to fix bug #139225, restricts maximum font size to that which will fit in the display.

Fix for bug #139225.  Ignores attempts to change the font to a size larger than
will fit in the display, adds an assertion to catch errors in this area
earlier.
Comment 4 Robert Knight 2006-12-26 19:00:46 UTC
Marking bug as fixed.  
Comment 5 Robert Knight 2006-12-26 19:02:15 UTC
Should have mentioned in previous comment:  Fix committed with SVN revision 616760.
Comment 6 Yuriy Kozlov 2007-01-26 08:19:36 UTC
I can still reproduce the crash in KDE 3.5.6

Was the fix committed to 3.5?
Comment 7 Robert Knight 2007-01-26 10:02:57 UTC
Yes, confirmed here as well.  The patch didn't completely solve the problem it seems.
Comment 8 Robert Knight 2007-01-26 10:04:24 UTC
Created attachment 19420 [details]
Better patch to fix the crash.

Better patch to fix the bug.  Use in addition to the previous patch.
Comment 9 Robert Knight 2007-05-08 01:06:23 UTC
Right, should be fixed for good in KDE 3.5.7