Bug 138976 - Some links are difficult to click in the documentation (docs.kde.org)
Summary: Some links are difficult to click in the documentation (docs.kde.org)
Status: RESOLVED FIXED
Alias: None
Product: docs.kde.org
Classification: Websites
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Documentation Editorial Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-18 18:09 UTC by Colin Finck
Modified: 2007-03-16 13:04 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
kdelibs/common/kde-default.css patch (350 bytes, patch)
2006-12-23 08:47 UTC, Rich Johnson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Finck 2006-12-18 18:09:35 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    Unspecified

Some links in the documentation web pages are difficult to click.
An example is the link "Mouse Buttons" at http://docs.kde.org/stable/en/kdebase/konsole/index.html
I think this is caused by the <span> tags around the word "Mouse".

I tested this with Firefox 1.5.0.8 and Internet Explorer 7.0 on Windows.
Comment 1 Matthew Flaschen 2006-12-19 09:54:14 UTC
Same thing in Firefox 2.0 on Kubuntu.
Comment 2 Frederik Schwarzer 2006-12-20 12:49:04 UTC
I rather suspect the hell of a definition list used for menu structure!

I do not know what spoke against using (un)ordered lists. :(

Anyway, I looked through the code and found another thing.

- <span> tags may only contain inline elements. I found several <br> tags inside <span> tags (search for "</span><br></span>")

This doesn't solve the problem but it's not good to have them here.


But. You seem to be right. When I take away the <span> tags, the link's klick areas are at the right place. Strange thing is:

I have the following code snipplet:
===
<dt><span class="chapter"><a href="http://docs.kde.org/stable/en/kdebase/konsole/introduction.html">1. Introduction to <span class="application">Konsole</span></a></span></dt>
<dd>
<dl>
<dt><span class="sect1"><a href="http://docs.kde.org/stable/en/kdebase/konsole/introduction.html#terminal">What is a terminal?</a></spa
n></dt>
<dt><span class="sect1"><a href="http://docs.kde.org/stable/en/kdebase/konsole/features.html">What makes <span class="application">Kons
ole</span> special?</a></span></dt>
===

Now, when I remove the <span> tags:
===
<dt><a href="http://docs.kde.org/stable/en/kdebase/konsole/introduction.html">1. Introduction to Konsole</a></dt>
<dd>
<dl>
<dt><a href="http://docs.kde.org/stable/en/kdebase/konsole/introduction.html#terminal">What is a terminal?</a></dt>
<dt><a href="http://docs.kde.org/stable/en/kdebase/konsole/features.html">What makes Konsole special?</a></dt>
===

everything works fine here, but when adding the <span>s in one line:
===
<dt><a href="http://docs.kde.org/stable/en/kdebase/konsole/introduction.html">1. Introduction to Konsole</a></dt>
<dd>
<dl>
<dt><a href="http://docs.kde.org/stable/en/kdebase/konsole/introduction.html#terminal">What is a terminal?</a></dt>
<dt><span class="sect1"><a href="http://docs.kde.org/stable/en/kdebase/konsole/features.html">What makes <span class="application">Konsole</span> special?</a></span></dt>
===

not the line itself is damaged, but the line above.

And it's definitely the <span class="sect1"> what causes the trouble.

cheers
Comment 3 Rich Johnson 2006-12-23 08:47:53 UTC
Created attachment 19012 [details]
kdelibs/common/kde-default.css patch

padding-left: 1em;

instead of

padding: 1em;

fixes this issue and closes this bug
Comment 4 Rich Johnson 2007-03-16 06:09:47 UTC
Has anyone taken a look at this? I know we discussed this one day in #kde-docs. The above change will fix this issue.
Comment 5 Anne-Marie Mahfouf 2007-03-16 13:04:57 UTC
SVN commit 643107 by annma:

apply patch to fix mouse click in docs thanks Richard
BUG=138976


 M  +1 -1      kde-default.css  


--- branches/KDE/3.5/kdelibs/doc/common/kde-default.css #643106:643107
@@ -52,7 +52,7 @@
 }
 
 .sect1, .chapter, .synopsis, .appendix, .preface, .article, .refsect1, .index, .glossary, .section {
-  padding: 1em;
+  padding-left: 1em;
 }
 
 .toc .chapter {