Bug 137912 - /tmp may not have enough space for magnatune plugin
Summary: /tmp may not have enough space for magnatune plugin
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.4.4
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-26 15:30 UTC by David Bremner
Modified: 2006-12-05 18:04 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
patch against magnatunealbumdownloader.cpp (1.74 KB, text/plain)
2006-11-30 04:34 UTC, David Bremner 		Details
patch against magnatunealbumdownloader.h (569 bytes, text/plain)
2006-11-30 04:36 UTC, David Bremner 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Bremner 2006-11-26 15:30:05 UTC 
Version:           1.4.4 (using KDE 3.5.5, Debian Package 4:3.5.5a.dfsg.1-5 (4.0))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17

My /tmp is only 180M so downloading large zip files there does not work
very well; the download dies without giving me any error feedback.

amarok should check to make sure there is space in the temporary directory, and perhaps have a configurable download directory.

If nothing else, it seems more likely that there will be space for the temporary file where the user has just selected to download to.
Comment 1 David Bremner 2006-11-30 04:34:55 UTC 
Created attachment 18727 [details]
patch against magnatunealbumdownloader.cpp

This, and the next attachment form give some idea of a patch. 
This crashes with today's SVN
Unfortunately it is a bit tricky for me to debug. I'm not sure I want to buy
that much music just now :-)
Comment 2 David Bremner 2006-11-30 04:36:49 UTC 
Created attachment 18728 [details]
patch against magnatunealbumdownloader.h

Please note, these patches need debugging, and are posted only for 
discussion
Comment 3 Nikolaj Hald Nielsen 2006-12-05 18:04:14 UTC 
I have committed your patch (with some changes, as it caused the album cover fetching and unpacking of downloaded albums to no longer work)

Marked as FIXED