Bug 137079 - provide accelerator keys for the menu
Summary: provide accelerator keys for the menu
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-09 08:59 UTC by Maciej Pilichowski
Modified: 2008-01-16 05:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2006-11-09 08:59:26 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs

I am aware of similarly titled report
https://bugs.kde.org/show_bug.cgi?id=28632

however it discusses shortcuts really, not accelerators.

Surprisingly, but Konsole does not provide accelerators for top menu entries. It is against HIG so I guess it should be classified as bug.

I use original, English version.
Comment 1 Robert Knight 2006-11-09 10:16:41 UTC
Confirmed.
Comment 2 Shriramana Sharma 2007-03-18 01:38:06 UTC
I don't see the difference between shortcuts and accelerators. Latest version of console allows you to use Ctrl+Alt+M to open the menu. Normal shortcuts cannot be used since Konsole may be displaying apps that use those shortcuts.

This bug should be marked FIXED.
Comment 3 Maciej Pilichowski 2007-03-18 09:18:51 UTC
> I don't see the difference between shortcuts and accelerators. 

Then it would be good to use google _first_, here:
http://developer.kde.org/documentation/standards/kde/style/keys/index.html
Comment 4 Shriramana Sharma 2007-03-18 11:20:43 UTC
My apologies for not googling, but still this bug should be marked fixed. Ctrl+Alt+M is an accelerator since it is used "to select an item which is visible on the screen". The reporter of this asked for accelerators. He got one. There is no need to provide accelerators for all menu items and possibly deprive apps running *within* console of their use. [BTW the other bug asked for either accelerators or shortcuts, not just shortcuts.]

P.S: Thank you for enlightening me, Maciej.
Comment 5 Maciej Pilichowski 2007-03-18 11:52:14 UTC
Shriramana, please, read it again (acc. vs shortcuts). I assure you Konsole does not support accelerators for opening menu (except for bare alt). Compare Konsole and Konqueror (top) menus for example -- you don't see those small underlines in Konsole, do you?

And I didn't write about any accelerator but those for top menu entries.
Comment 6 Shriramana Sharma 2007-03-18 17:45:35 UTC
OK -- now Ctrl+Alt+M does not have all the qualities of either a strict accelerator:

1. it is an alphanumeric key combined with a meta key that selects a visible widget
2. BUT it is not an underlined letter
3. and it is not subject to translation

It also does not have the qualities of a strict shortcut since it does not start an action from any menu -- instead it starts the menu itself.

So what do you want? It is clear in the other bug that accelerators even for the top menu entries cannot be provided in Konsole as Alt+key combinations are quite likely to be used in terminal applications. 

If you ask for shortcuts -- for example to open a new shell etc, it might be useful. There are already some such items -- Shift+Ins for the Paste action for example. 

You can draw out a nice useful shortcut list for various Konsole actions and ask for it to be implemented. But if you ask for accelerators, you will likely not get it for reasons already stated in that bug.

I hope this is clear.
Comment 7 Maciej Pilichowski 2007-03-18 22:38:06 UTC
> accelerators even for the top menu entries cannot be provided in Konsole as
> Alt+key combinations are quite likely to be used in terminal applications.

"Quite likely"? If anyone sees REAL conflict, then change this report for a optional accelerators. For me, over years of using linux, the only key combination in terminals I use are still: ctrl+c; ctrl+d; ctrl+x s. That's it. It is more productive for me to have alt+v assigned as accelerator and using it NOW, then waiting for some potential conflict, which MAYBE occur in some future.
I don't deny the possibility of conflict, but cannot we go forward just of existence of some terminal app? Really?
Comment 8 Shriramana Sharma 2007-03-18 22:58:17 UTC
Maciej, sadly it must be so - if we do not allow for such an application today, then tomorrow some other Shriramana will come and file a bug saying "Konsole should not have accelerators". But optional accelerators, as you say, is ok -- put the responsibility on the user. But the default must be OFF.
Comment 9 Robert Knight 2007-07-29 05:22:15 UTC
Fixed in KDE 4.  Konsole menu has accelerators for the majority of actions.

There is a slight difference in how they are activated.  Rather than pressing and holding Alt and then pressing the letter, the accelerator is activated by pressing and releasing the Alt key and then pressing the letter.

This allows the accelerators to work as well as Alt+Letter commands to the terminal without requiring an additional option somewhere.  The downside is that the lack of consistency may confuse users, I'll have to see pending feedback from the betas.






Comment 10 Maciej Pilichowski 2007-11-03 16:01:31 UTC
Robert, I just reported a wish that could solve this problem:
https://bugs.kde.org/show_bug.cgi?id=151811

This way both features would be great adds -- with being able to configure accelerators:
(*) use "delayed" accelerators (the way you described them)
( ) use normal KDE accelerators -- and then "press key" would come handy

This way user could choose if she/he works more with older program that requires pressing a lot of alt+s or is it rather more handy to have "normal" alt+s accelerators.

Since this is new idea I am reopening this wish, ok?
Comment 11 Thomas Zander 2007-12-17 20:00:26 UTC
Fixed in kde4
Comment 12 Ismail Donmez 2008-01-16 05:27:31 UTC
This is very very confusing and not in sync with rest of the KDE. Best would be do it like Windows where you have to tap Alt key twice to activate the accessors and tap Alt key again to disable them.