Bug 136822 - kmines Makefile has bashism
Summary: kmines Makefile has bashism
Status: RESOLVED WORKSFORME
Alias: None
Product: kmines
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Suzdalev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-04 16:47 UTC by alancio
Modified: 2008-11-20 15:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Fixes to kmines, kfouleggs, klickety and ksirtet Makefiles (7.18 KB, patch)
2007-01-27 10:13 UTC, alancio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description alancio 2006-11-04 16:47:24 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    Compiled From Sources
OS:                Linux

If you are not using bash as your /bin/sh, kmines building process fails with the following errors:


make[2]: Entering directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
make[3]: Entering directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
test -z "/usr/bin" || mkdir -p -- "/usr/ports/work/kdegames/pkg/usr/bin"
  /bin/sh ../libtool --silent --mode=install /usr/bin/install -c -p  'kmines' '/usr/ports/work/kdegames/pkg/usr/bin/kmines'
make  install-exec-hook
make[4]: Entering directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
/bin/sh: syntax error: '(' unmatched
make[4]: *** [install-exec-hook] Error 1
make[4]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
make[3]: *** [install-exec-am] Error 2
make[3]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/usr/ports/work/kdegames/src/kdegames-3.5.5/kmines'
make: *** [install-recursive] Error 1
Comment 1 alancio 2007-01-27 10:13:14 UTC
Created attachment 19437 [details]
Fixes to kmines, kfouleggs, klickety and ksirtet Makefiles

Apply the patch as follows:

patch -p1 < /var/tmp/kdegames-sh.patch
automake
perl admin/am_edit

Then run configure, make, make install as usual.
Comment 2 alancio 2007-01-27 10:15:19 UTC
By the way, I made this patch for kdegames 3.5.6, but it must work for 3.5.5 too, let me know.
Comment 3 Albert Astals Cid 2008-05-12 12:16:02 UTC
The patch seems wrong, if i apply it i get 

Error: Could not install the game with correct permissions !!
Error: Could not create the highscore directory with correct permissions !!
Error: Could not install the game with correct permissions !!
Error: Could not install the game with correct permissions !!
Error: Could not create system-wide highscore file with correct permissions !!

Which does not happen if i do not apply it.
Comment 4 alancio 2008-05-12 15:42:14 UTC
Albert,

I'm sure you got the same messages without applying the patch, but you just didn't notice them.

This patch is to solve the bashisms in the makefiles, if you want correct system permissions you have to be root.
Comment 5 FiNeX 2008-11-20 15:32:49 UTC
kmines compiles right on current trunk.