Version: 1.4.4 (using KDE KDE 3.5.5) Installed from: Ubuntu Packages OS: Linux I'm running Amarok compiled from svn, on top of Gnome (Ubuntu). Links in the ContextBrowser prefixed with externalurl: are supposed to open in the web browser set in Amarok's preferences. I've tried setting the browser there, and everywhere else I can think of, but linked pages are always downloaded and opened in Firefox from /var/tmp/kdecache... This isn't a real solution, but it works for now: Index: app.cpp =================================================================== --- app.cpp (revision 600791) +++ app.cpp (working copy) @@ -1225,7 +1225,7 @@ bool invokeBrowser( const QString& url ) { //URL can be in whatever forms KURL::fromPathOrURL understands - ie most. - return KRun::run( AmarokConfig::externalBrowser(), KURL::List( KURL::fromPathOrURL( url ) ) ) > 0; + return KRun::runURL( KURL::fromPathOrURL( url ), QString("text/html")) > 0; } namespace ColorScheme
i can confirm this bug, but i'm not convinced with the fix. seems like it wouldn't take the custom browser setting into account
It will run the browser set for kde.
*** Bug 136758 has been marked as a duplicate of this bug. ***
*** Bug 136863 has been marked as a duplicate of this bug. ***
Apparently the browser preference setting in Amarok is there because people who aren't running KDE (allowing dependency on only kdelibs) wouldn't be able to set the default KDE browser to open URLs. Doesn't KDE respect the default browser set in Gnome, or by using 'update-alternatives --config x-www-browser'?
1) Anything that worked in former versions but doesn't in a new one is _not_ apparent. 2) Setting General: External Web Browser to "konqueror" (instead of the "Default KDE Browser") results in a display w/o CSS and images, all HTML <form> elements are useless since they point to non-existent files on the local disk which aren't there and wouldn't work if they would be there since the functionality relies on server side scripting and DB retrieval.
*** Bug 136896 has been marked as a duplicate of this bug. ***
Jo, I'm afraid you misunderstood my point above. I'd asked in IRC why there was a browser setting within Amarok, rather than just using the system setting, and was told that it was needed for people who aren't running KDE and so don't have access to kcontrol to set KDE's default browser. The patch posted above ignores Amarok's browser setting, so I was asking if there was another way to set KDE's default browser for people who aren't running the full KDE desktop.
SVN commit 602316 by aoliveira: Url's would open in external browser from cache. BUG: 136598 M +3 -2 app.cpp [POSSIBLY UNSAFE: KRun::runCommand] --- trunk/extragear/multimedia/amarok/src/app.cpp #602315:602316 @@ -1225,7 +1225,8 @@ bool invokeBrowser( const QString& url ) { //URL can be in whatever forms KURL::fromPathOrURL understands - ie most. - return KRun::run( AmarokConfig::externalBrowser(), KURL::List( KURL::fromPathOrURL( url ) ) ) > 0; + const QString cmd = "%1 \"%2\""; + return KRun::runCommand( cmd.arg( AmarokConfig::externalBrowser(), KURL::fromPathOrURL( url ).url() ) ) > 0; } namespace ColorScheme @@ -1314,7 +1315,7 @@ result.ref( i ) = c; } return result; - } + } QString vfatPath( const QString &path ) {
*** Bug 137054 has been marked as a duplicate of this bug. ***