Bug 136355 - add "Search in Google for this lyric" message when finding no lyrics
Summary: add "Search in Google for this lyric" message when finding no lyrics
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-26 20:35 UTC by Sven Krohlas
Modified: 2006-10-27 22:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Krohlas 2006-10-26 20:35:08 UTC 
Version:           1.4.4 SVN (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs
Compiler:          gcc version 4.0.2 20050901 (prerelease) (SUSE Linux) 
OS:                Linux

Currently if the lyrics browser can't find lyrics or there is a timeout you simply get an error message. These messages could be enhanced with a link to a Google search for that lyric to make the search feature easier to discover.
Comment 1 Alexandre Oliveira 2006-10-27 22:14:22 UTC 
SVN commit 599604 by aoliveira:

When the script can't find lyrics, provide a link for a web search.
BUG: 136355


 M  +2 -0      contextbrowser.cpp  


--- trunk/extragear/multimedia/amarok/src/contextbrowser.cpp #599603:599604
@@ -3049,6 +3049,8 @@
                 lyrics += "</a><br/>\n";
             }
         }
+        lyrics += i18n( "<p>You can <a href=\"%1\">search for the lyrics</a> on the Web.</p>" )
+                  .arg( QString( m_lyricSearchUrl ).replace( QRegExp( "^http:" ), "externalurl:" ) );
     }
     else {
         lyrics = el.text();