Bug 136233 - ipod upload does not ignore common words like 'the'
Summary: ipod upload does not ignore common words like 'the'
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Collections/iPod iPhone (show other bugs)
Version: 1.4.3
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-24 14:11 UTC by Hiren Joshi
Modified: 2011-12-20 11:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hiren Joshi 2006-10-24 14:11:43 UTC
Version:           1.4.3 (using KDE KDE 3.5.5)
Installed from:    Fedora RPMs

After uploading my MP3s onto my iPod through Amarok, I noticed all the artists with 'the' at the begining are filed under 'T'. Amarok does the right thing by ignoring the 'the' from the artist when sorting but the iPod doesn't.

Is the a feature that can be implemented in Amarok or is this an iPod issue?

Thanks,
Josh
Comment 1 Martin Aumueller 2006-10-24 14:23:50 UTC
Where do you have this problem? In Amarok's iPod view or on your iPod (when it is disconnected from your computer and you are using it for listening to music)?
Comment 2 Hiren Joshi 2006-10-24 15:18:36 UTC
Firstly, thanks for a prompt response.

Amarok's collection, “The Crystal Method” is filed under “C”.

On the iPod view in amarok, “The Crystal Method” is filed under “T”.

On the iPod (disconnected), “The Crystal Method” is filed under “T”.
Comment 3 Martin Aumueller 2006-10-24 17:20:12 UTC
Did you set the language on your ipod to English? I think the ipod depends on this setting for ordering the artists.

In Amarok's ipod view we didn't yet implement this feature.
Comment 4 Hiren Joshi 2006-10-24 18:10:27 UTC
Yes it's set to English.

This is looking like an iPod issue rather than an Amarok one.

Thanks.
Comment 5 Martin Aumueller 2006-10-25 01:34:32 UTC
SVN commit 598907 by aumuell:

ignore leading "the " when ordering artists
BUG: 136233


 M  +1 -0      ChangeLog  
 M  +11 -0     src/mediabrowser.cpp  


--- trunk/extragear/multimedia/amarok/ChangeLog #598906:598907
@@ -30,6 +30,7 @@
 
 
   CHANGES:
+    * Ignore leading "The " when sorting artists on media devices. (BR 136233)
     * Improved handling of VFAT/ASCII files and paths when organizing the
       collection and using the Generic media device.
     * Enable playing audio CDs on CD insert. Patch by Will Stephenson
--- trunk/extragear/multimedia/amarok/src/mediabrowser.cpp #598906:598907
@@ -1052,7 +1052,18 @@
     MediaItem *item = dynamic_cast<MediaItem *>(i);
     if(item && col==0 && item->m_order != m_order)
         return m_order-item->m_order;
+    else if( item->type() == MediaItem::ARTIST )
+    {
+        QString key1 = key( col, ascending );
+        if( key1.startsWith( "the ", false ) )
+            key1 = key1.mid( 4 );
+        QString key2 = i->key( col, ascending );
+        if( key2.startsWith( "the ", false ) )
+            key2 = key2.mid( 4 );
 
+       return key1.localeAwareCompare( key2 );
+    }
+
     return KListViewItem::compare(i, col, ascending);
 }
 
Comment 6 Seb Ruiz 2006-10-25 03:47:26 UTC
for what its worth, my ipod has always ignore "the " when listing
artists, albums and songs.  Nothing to do with Amarok there.

On 24 Oct 2006 23:34:33 -0000, Martin Aumueller <aumuell@reserv.at> wrote:
[bugs.kde.org quoted mail]
Comment 7 Hiren Joshi 2006-10-27 13:11:20 UTC
Hi,
I'd like to reopen this bug. I pluged my iPod into the Mac and it started doing the right thing ie. the 'the' in the artisis name is ignored on the search.

Have you had any other reports like this for 5th Gen iPods?
Comment 8 Seb Ruiz 2006-10-27 15:00:02 UTC
I've never had any problems like this.  Even when amarok did not ignore "the" in the ipod view, browsing the collection from within the disconnected ipod listed the tracks fine.

Make sure you are using libgpod 0.4.0.
Comment 9 Hiren Joshi 2006-10-27 16:00:05 UTC
libgpod.i386 0.4.0-0.fc6 installed

I'll wait for more updates etc. I can do the workaround by plugung into the Mac for now. I also have a problem with Bug 133571 so untill thats resolved. I'll see if I still get the problem.

Thanks for your help.
Comment 10 Chris Pimlott 2007-06-15 04:48:10 UTC
I'm seeing the same issue here -

id3 tag - The Arcade Fire
amarok collection - sorted under A
amarok device view - sorted under A
ipod artists view - sorted under T

etc. for all artists starting with "The".

Using Amarok 1.4.5 and libgpod1 0.4.2 under Ubuntu 7.04.  The iPod is a 6th gen 80 GB with language set as English.


Comment 11 Chris Pimlott 2007-06-25 13:00:29 UTC
Note that this is not an iPod issue, as the iPod relies on information in the iTunesDB for sorting entries, which contains a second "Artist" field for sorting purposes:

 Artist name, for sorting. Artists with names like "The Beatles" will be in here as "Beatles, The". Introduced in db version 0x13?

- Taken from http://www.ipodlinux.org/ITunesDB#Data_Object

Perhaps early iPods did, in fact, contain their own sorting logic based on language, which might explain why some developers aren't seeing this occur.  This would make sense as the sort field was not present in early iTunesDB versions.