135995 – organise files dialog: weird spaces in layout with details off

Bug 135995 - organise files dialog: weird spaces in layout with details off

Summary: organise files dialog: weird spaces in layout with details off

Status:	RESOLVED FIXED

Alias:	None

Product:	amarok
Classification:	Applications
Component:	general (show other bugs)
Version:	1.4-SVN
Platform:	unspecified Linux

Importance:	NOR wishlist
Target Milestone:	---
Assignee:	Amarok Developers

URL:
Keywords:

Depends on:
Blocks:

Reported:	2006-10-20 01:36 UTC by baum-im-wald
Modified:	2006-10-22 12:52 UTC (History)
CC List:	0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description baum-im-wald 2006-10-20 01:36:15 UTC

Version:           1.4-SVN (using KDE 3.5.5, Kubuntu (dapper) 4:3.5.5-0ubuntu1)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-23-386

when turning the detailed option in the organise files dialog off, the window looks somewhat weird:

-there is a space below the two checkboxes in the first group box
-there is an even larger space below the preview in the second group box

it would be nice if the window was smaller and the group boxes were less high.

Comment 1 Alexandre Oliveira 2006-10-22 12:52:01 UTC

SVN commit 598017 by aoliveira:

Improve layout of organize files dialog a bit.
BUG: 135995


 M  +93 -18    organizecollectiondialog.ui  


--- trunk/extragear/multimedia/amarok/src/organizecollectiondialog.ui #598016:598017
@@ -10,7 +10,7 @@
             <x>0</x>
             <y>0</y>
             <width>476</width>
-            <height>561</height>
+            <height>549</height>
         </rect>
     </property>
     <property name="sizePolicy">
@@ -79,25 +79,52 @@
                 </widget>
             </hbox>
         </widget>
-        <widget class="QCheckBox">
+        <widget class="QLayoutWidget">
             <property name="name">
-                <cstring>coverCheck</cstring>
+                <cstring>layout5</cstring>
             </property>
-            <property name="text">
-                <string>&amp;Use Cover Art for Folder Icons</string>
-            </property>
+            <vbox>
+                <property name="name">
+                    <cstring>unnamed</cstring>
+                </property>
+                <widget class="QCheckBox">
+                    <property name="name">
+                        <cstring>coverCheck</cstring>
+                    </property>
+                    <property name="text">
+                        <string>&amp;Use Cover Art for Folder Icons</string>
+                    </property>
+                </widget>
+                <widget class="QCheckBox">
+                    <property name="name">
+                        <cstring>ignoreTheCheck</cstring>
+                    </property>
+                    <property name="text">
+                        <string>I&amp;gnore 'The' in Artist Names</string>
+                    </property>
+                    <property name="toolTip" stdset="0">
+                        <string>If checked, postfix artists' names starting with 'The' with ', The'.</string>
+                    </property>
+                </widget>
+            </vbox>
         </widget>
-        <widget class="QCheckBox">
+        <spacer>
             <property name="name">
-                <cstring>ignoreTheCheck</cstring>
+                <cstring>spacer2_5</cstring>
             </property>
-            <property name="text">
-                <string>I&amp;gnore 'The' in Artist Names</string>
+            <property name="orientation">
+                <enum>Vertical</enum>
             </property>
-            <property name="toolTip" stdset="0">
-                <string>If checked, postfix artists' names starting with 'The' with ', The'.</string>
+            <property name="sizeType">
+                <enum>Expanding</enum>
             </property>
-        </widget>
+            <property name="sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>16</height>
+                </size>
+            </property>
+        </spacer>
         <widget class="QGroupBox">
             <property name="name">
                 <cstring>groupingGroup</cstring>
@@ -201,6 +228,23 @@
                 </widget>
             </vbox>
         </widget>
+        <spacer>
+            <property name="name">
+                <cstring>spacer2_4</cstring>
+            </property>
+            <property name="orientation">
+                <enum>Vertical</enum>
+            </property>
+            <property name="sizeType">
+                <enum>Expanding</enum>
+            </property>
+            <property name="sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>16</height>
+                </size>
+            </property>
+        </spacer>
         <widget class="QGroupBox">
             <property name="name">
                 <cstring>replacementGroup</cstring>
@@ -303,6 +347,23 @@
                 </widget>
             </vbox>
         </widget>
+        <spacer>
+            <property name="name">
+                <cstring>spacer2</cstring>
+            </property>
+            <property name="orientation">
+                <enum>Vertical</enum>
+            </property>
+            <property name="sizeType">
+                <enum>Expanding</enum>
+            </property>
+            <property name="sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>16</height>
+                </size>
+            </property>
+        </spacer>
         <widget class="QGroupBox">
             <property name="name">
                 <cstring>previewBox</cstring>
@@ -343,15 +404,12 @@
         </widget>
         <widget class="QLayoutWidget">
             <property name="name">
-                <cstring>overwriteLayout</cstring>
+                <cstring>layout7</cstring>
             </property>
             <hbox>
                 <property name="name">
                     <cstring>unnamed</cstring>
                 </property>
-                <property name="margin">
-                    <number>5</number>
-                </property>
                 <spacer>
                     <property name="name">
                         <cstring>spacer2_2</cstring>
@@ -364,7 +422,7 @@
                     </property>
                     <property name="sizeHint">
                         <size>
-                            <width>40</width>
+                            <width>347</width>
                             <height>20</height>
                         </size>
                     </property>
@@ -382,6 +440,23 @@
                 </widget>
             </hbox>
         </widget>
+        <spacer>
+            <property name="name">
+                <cstring>spacer2_3</cstring>
+            </property>
+            <property name="orientation">
+                <enum>Vertical</enum>
+            </property>
+            <property name="sizeType">
+                <enum>Expanding</enum>
+            </property>
+            <property name="sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>16</height>
+                </size>
+            </property>
+        </spacer>
     </vbox>
 </widget>
 <customwidgets>