Bug 135540 - JJ: Javascript Code Generation creates bad format methods (operations)
Summary: JJ: Javascript Code Generation creates bad format methods (operations)
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-12 22:18 UTC by ediaz666@gmail.com
Modified: 2007-02-12 15:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch for bug #135540 (646 bytes, patch)
2007-02-11 21:28 UTC, Antoine Dopffer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ediaz666@gmail.com 2006-10-12 22:18:56 UTC
Version:           1.5.5 (using KDE 3.5.5 "release 19.1" , openSUSE )
Compiler:          Target: x86_64-suse-linux
OS:                Linux (x86_64) release 2.6.16.13-4-default

Javascript Code Generator returns bad format operations:
  ....
  ClassA.prototype.method1 function( param1 )
  ....

it doesn't put the = sign between method's name and the function declaration
Comment 1 Oliver Kellogg 2006-11-20 21:13:20 UTC
Another Junior Job candidate.
Comment 2 Antoine Dopffer 2007-02-11 21:28:50 UTC
Created attachment 19624 [details]
patch for bug #135540

Hello,

the bug was in file codegenerators/jswriter.cpp
This was indeed a junior job.

Have a nice day
Comment 3 Oliver Kellogg 2007-02-12 15:05:34 UTC
SVN commit 632848 by okellogg:

writeOperations(): Aply attachment 19624 [details] from Antoine Dopffer.
Thanks Antoine for contributing.
BUG:135540


 M  +4 -0      ChangeLog  
 M  +1 -1      umbrello/codegenerators/jswriter.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/ChangeLog #632847:632848
@@ -1,3 +1,7 @@
+Version 1.5.7
+* Bugs fixed from http://bugs.kde.org:
+* Javascript Code Generation creates bad format methods (135540)
+
 Version 1.5.61
 
 * Copy/paste of attribute or operation in list view within same class
--- branches/KDE/3.5/kdesdk/umbrello/umbrello/codegenerators/jswriter.cpp #632847:632848
@@ -223,7 +223,7 @@
             js << " */" << m_endl;
         }//end if : write method documentation
 
-        js << classname << ".prototype." << cleanName(op->getName()) << " function " << "(";
+        js << classname << ".prototype." << cleanName(op->getName()) << " = function " << "(";
 
         int i = atl.count();
         int j=0;