Bug 134803 - do *not* delete files if the user sets them to do not download them in the files tab
Summary: do *not* delete files if the user sets them to do not download them in the fi...
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-28 20:42 UTC by Stephen Leaf
Modified: 2006-11-21 18:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Leaf 2006-09-28 20:42:33 UTC
Version:            (using KDE KDE 3.5.4)
Installed from:    Compiled From Sources

While downloading a torrent I decided that I only wanted it to download 1 file at that moment, so I unchecked them all but one. Then I noticed in my directory that it had deleted everything that was unchecked without notifying me.
Luckally this was a torrent resumed from pre-existing data that I had on CD. However the 16+ hours worth of downloading that I had already done is now gone.
Comment 1 Stephen Leaf 2006-09-28 20:50:24 UTC
Just found this:
bug #130507
Is this fixed in svn? or was this supposedly fixed in 2.0.2
Comment 2 Joris Guisson 2006-09-29 19:26:27 UTC
That's just a confirmation dialog, we are adding an option to support what you want and what currently is done. So you will be able to keep the data of a deselected file.
Comment 3 Joris Guisson 2006-10-01 10:59:00 UTC
SVN commit 590891 by guisson:

Changes :
- Fixed bug in advanced choke algorithm
- Deselecting files without deleting data is now possible
- Deselecting files without deleting data is now the default action when you uncheck a file in the infowdiget
- Deselecting existing files at torrent load time, will not delete the file

BUG: 134803
BUG: 134597



 M  +26 -12    libktorrent/interfaces/filetreediritem.cpp  
 M  +4 -3      libktorrent/interfaces/filetreediritem.h  
 M  +78 -43    libktorrent/interfaces/filetreeitem.cpp  
 M  +8 -3      libktorrent/interfaces/filetreeitem.h  
 M  +12 -1     libktorrent/torrent/chunk.h  
 M  +66 -17    libktorrent/torrent/chunkmanager.cpp  
 M  +18 -1     libktorrent/torrent/chunkmanager.h  
 M  +2 -1      libktorrent/torrent/chunkselector.cpp  
 M  +6 -5      libktorrent/torrent/downloader.cpp  
 M  +2 -3      libktorrent/torrent/peer.cpp  
 M  +1 -1      libktorrent/torrent/peer.h  
 M  +1 -1      libktorrent/torrent/peeruploader.cpp  
 M  +3 -3      libktorrent/torrent/torrentcontrol.cpp  
 M  +10 -1     libktorrent/util/constants.h  
 M  +68 -19    plugins/infowidget/infowidget.cpp  
 M  +4 -2      plugins/infowidget/infowidget.h  
 M  +12 -5     plugins/infowidget/iwfiletreediritem.cpp  
 M  +1 -1      plugins/infowidget/iwfiletreediritem.h  
 M  +16 -10    plugins/infowidget/iwfiletreeitem.cpp  
 M  +1 -1      plugins/infowidget/iwfiletreeitem.h  
Comment 4 S. Burmeister 2006-11-21 17:24:04 UTC
Is this fix in 2.0.3 (which was released after this commit) or will it be part of 2.0.4?
Comment 5 Joris Guisson 2006-11-21 18:52:45 UTC
It will be in 2.1beta1, there is not gonna be a 2.0.4, 2.1beta1 will be released today or tomorrow.