Bug 133949 - Renaming sessions changes current tab name
Summary: Renaming sessions changes current tab name
Status: RESOLVED REMIND
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Robert Knight
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-12 10:40 UTC by Henry Malthus
Modified: 2009-03-14 05:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
proposed patch to fix this bug (563 bytes, patch)
2006-09-12 10:47 UTC, Henry Malthus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Malthus 2006-09-12 10:41:05 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 4.1.2 
OS:                Linux

Renaming a session changes the current tab name, regardless of which session you are trying to change the name of.

Steps to reproduce:
* open a couple of sessions in Konsole
* switch to the first one
* right click on another session's tab, select 'Rename...'
* fill in the dialog, and press enter

You'll see that the current tab's title gets changes to whatever was entered.

I would expect that the title of the tab that was renamed gets changed, and the current tab's title stays the same.

Interesting to note that, the name of the session does get changed, it's just that the wrong tab title does also.
Comment 1 Henry Malthus 2006-09-12 10:47:28 UTC
Created attachment 17735 [details]
proposed patch to fix this bug

Really simple fix, se is the current session, whereas ses is the session passed
to slotRenameSession.

As you can see, beforehand the current tab's title was being changed regardless
of which session was passed to slotRenameSession.

Patch applies to current SVN (r583392). Perhaps should be back-ported for KDE
3.5.5, if there is going to be one?
Comment 2 Robert Knight 2007-02-10 04:03:01 UTC
A backport to KDE 3.5.5 would be worthwhile.  I'm afraid that a patch against trunk won't be very useful given that much of that code is being replaced.
Comment 3 Kurt Hindenburg 2009-03-14 05:02:46 UTC
This bug doesn't apply to KDE4 at all.  I'll leave it REMIND in case anyone releases another version of KDE3.5.