Bug 133873 - systray icon could reflect upload/download activity by blinking
Summary: systray icon could reflect upload/download activity by blinking
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-10 19:52 UTC by Marcel Partap
Modified: 2006-10-04 21:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
add speed bar (9.64 KB, patch)
2006-10-01 12:37 UTC, Diego R. Brogna
Details
snapshot (1.04 KB, image/png)
2006-10-02 20:26 UTC, Diego R. Brogna
Details
speed bar (3.10 KB, application/gzip)
2006-10-03 17:03 UTC, Diego R. Brogna
Details
speed bar (41.08 KB, patch)
2006-10-03 19:05 UTC, Diego R. Brogna
Details
KTorrent system tray icon snapshot. (11.77 KB, image/png)
2006-10-03 21:19 UTC, Ivan Vasic
Details
KTorrent system tray icon snapshot. (14.35 KB, image/png)
2006-10-03 22:14 UTC, Ivan Vasic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Partap 2006-09-10 19:52:29 UTC
Version:           2.1dev (using KDE 3.5.4, Gentoo)
Compiler:          Target: x86_64-pc-linux-gnu
OS:                Linux (x86_64) release 2.6.18-rc4-no1

there's a red and a green arrow, symboling up and download. Would sure be cool to have them reflect current traffic situation, i.e. desaturate or highlight each of them if traffic is low/high...
useless but candy, cheers and thx for a great tool ;)
Comment 1 Joris Guisson 2006-09-11 18:22:12 UTC
That would be cool, we will see if we have the time to do this.
Comment 2 Diego R. Brogna 2006-10-01 12:37:31 UTC
Created attachment 17979 [details]
add speed bar
Comment 3 Diego R. Brogna 2006-10-01 12:37:54 UTC
hi
this patch add 2 small vertical bar on the tray icon green one for download and red one for upload
Comment 4 Joris Guisson 2006-10-02 18:14:25 UTC
The bars are not really that clear to see.
Comment 5 Diego R. Brogna 2006-10-02 20:25:19 UTC
enlarging the bars when bandwidth usage grow you can't see the icon. A solution should be make the bars transparent but i don't know how do this
Comment 6 Diego R. Brogna 2006-10-02 20:26:09 UTC
Created attachment 17995 [details]
snapshot
Comment 7 Ivan Vasic 2006-10-02 23:04:47 UTC
It covers KT icon and it doesn't look good to me although it's kinda usefull since I'm getting a good bandwidth overview in systray without opening KT.

My idea was to make these bars transparent too, but I'm not sure if this is easily done with Qt3. We should check out how amaroK does icon animations.
Comment 8 Diego R. Brogna 2006-10-03 17:03:51 UTC
Created attachment 17997 [details]
speed bar

now bars are transparent
copy in apps/ktorrent/ png files
Comment 9 Ivan Vasic 2006-10-03 18:05:49 UTC
It looks better. I would just add one small thing: since many people have smaller upload capacity than download, I'll add 'bandwidth' setting for upload too. That way if I have, for example, 100KB/s download and 10KB/s upload bars would show equal heights when reaching maximum capacities.

I would also make those bars a bit more transparent and much less wide so they don't cover KT icon too much (only images need to be changed for this so don't worry about it, I'm going to do it).
Comment 10 Diego R. Brogna 2006-10-03 18:10:51 UTC
thanks for the suggestion i will add upload bandwidth setting
Comment 11 Diego R. Brogna 2006-10-03 19:05:15 UTC
Created attachment 18001 [details]
speed bar

added upload bandwidth setting
Comment 12 Ivan Vasic 2006-10-03 21:18:37 UTC
It works great.

I've done some tweaking (you'll kill me):

- I made KT tray icon 2 pixels smaller in width (squeezed it actually)
- Squeezed speedbars too so they are 1px in width and placed download bar to the left and upload to the right. 

This way everything is clearly visible and icon is not covered.

What do you think?
Comment 13 Ivan Vasic 2006-10-03 21:19:52 UTC
Created attachment 18002 [details]
KTorrent system tray icon snapshot.

Snapshot
Comment 14 Diego R. Brogna 2006-10-03 21:28:38 UTC
i like it. I think that is the better solution, perhaps 2px in width is more visible 
Comment 15 Ivan Vasic 2006-10-03 22:14:40 UTC
Created attachment 18003 [details]
KTorrent system tray icon snapshot.

Maybe something like this?

Note that this is without modifying KTorrents tray icon. Seems pretty fine to
me...
Comment 16 Diego R. Brogna 2006-10-03 22:25:31 UTC
Great. I think that now is perfect
Comment 17 Marcel Partap 2006-10-04 01:38:32 UTC
Hey that looks pretty cool to me aswell will recompile in a minute.. I had animating the saturation/hue of the color of the arrows and/or the size of each arrow in mind when I posted, though... maybe someone can come up with useful code..^^
Comment 18 Ivan Vasic 2006-10-04 21:00:19 UTC
SVN commit 592422 by ivasic:

Systray now reflects current bandwidth usage.

Big thanks to Diego R. Brogna <dierbro@gmail.com> for providing this patch.

BUG:133873

 M  +1 -1      Makefile.am  
 M  +470 -329  generalpref.ui  
 AM            hi22-app-ktdownloadbar.png  
 AM            hi22-app-ktuploadbar.png  
 M  +1 -1      ktorrent.cpp  
 M  +16 -0     ktorrent.kcfg  
 M  +6 -0      pref.cpp  
 M  +27 -1     trayicon.cpp  
 M  +9 -1      trayicon.h