Bug 133864 - filebrowser doesn't get updated, kded module needed
Summary: filebrowser doesn't get updated, kded module needed
Status: RESOLVED NOT A BUG
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-10 16:37 UTC by Carsten Lohrke
Modified: 2006-09-11 22:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Lohrke 2006-09-10 16:37:54 UTC
Version:            (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages

When files change, one has explicitly to press F5 to see th changed date in Amarok's filebrowser tab.


According to the ForwardingSlaveBase documentation, it's necessary to write some notifier code:

# If you want view on directories to be correctly refreshed when something
# changes on a forwarded URL, you'll need a companion kded module to emit the
# KDirNotify Files*() DCOP signals.

# This class was initially used for media:/ ioslave. This ioslave code and the
# MediaDirNotify class of its companion kded module can be a good source of
# inspiration.
Comment 1 Carsten Lohrke 2006-09-10 16:38:23 UTC
s/date/data
Comment 2 Seb Ruiz 2006-09-10 16:48:16 UTC
Filebrowser updates automatically for me.

Anyway, bug reports without version numbers are invalid.
Comment 3 Carsten Lohrke 2006-09-10 17:43:14 UTC
Sorry for missing the version - 1.4.3 - and being as blind as I am. Looking at the code you're directly interfacing with inotify, instead using the ioslave. The problem is that you check for linux/inotify.h, while Gentoo/Glibc 2.4 has sys/inotify.h. Would be nice if you'd check for it, too.
Comment 4 Ian Monroe 2006-09-10 20:40:48 UTC
I don't get this bug. In the summary you put what the issue is. Your not running the correct kded module.

We don't use inotify, your looking at code that isn't compiled.
Comment 5 Carsten Lohrke 2006-09-11 21:56:35 UTC
Guys, all I dare to ask is, that you do not only check for linux/inotify.h in amarok/configure.in.in, but also for sys/inotify.h.
Comment 6 Alexandre Oliveira 2006-09-11 22:51:12 UTC
Dude, we *don't* use inotify directly at the moment. It's completly disabled.
The check won't change filebrowser's behaviour at all, as that check only affects Amarok's code. Filebrowser has never directly interfaced with inotify in Amarok. I don't really know which code you've been looking.
All refereces to HAVE_INOTIFY (in Amarok source) don't make any difference for amarok at the moment (in collectiondb.cpp we undefine it, in threadweaver it doesn't do anything revelant).

Btw, if you use Gentoo and doesn't have linux/inotify.h, then you probably got an old linux-headers package, and inotify won't work anyway. 
Kdelibs does use inotify when available, and the fact you have old linux headers is probably the real cause for the fact it doesn't work.
Follow Gentoo's guides on upgrading linux-headers (they should mention you'll have to recompile glibc after upgrading the linux-headers). You need >=linux-headers-2.6.16.