Bug 133548 - When there's no collection, Context Browser isn't shown even for streams
Summary: When there's no collection, Context Browser isn't shown even for streams
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.4.2
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-04 16:12 UTC by Sebastian Buch
Modified: 2006-09-07 01:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Buch 2006-09-04 16:12:52 UTC 
Version:           1.4.2 (using KDE 3.5.4, Kubuntu Package 4:3.5.4-0ubuntu2~dapper1 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-26-386

When using Last.FM it is needed to have a collection of music stored into the program to see . Since I am using Amarok only with a USB-Disk which I mount with the Media-Player-Browser, in my case the collection is not needed.

Please change it so that you are able to see the Kontext Menu even if there is no collection of music.

Thanks a lot.
Comment 1 Seb Ruiz 2006-09-04 17:10:31 UTC 
Amarok won't function properly without the context browser.

In 1.4.2, you can use the USB disk as a removable drive, as part of a dynamic collection.  When the device gets inserted/removed, then the collection will add/remove the appropriate songs as required automatically.

So, no need to use it as a media device.
Comment 2 Sebastian Buch 2006-09-04 17:34:01 UTC 
What about users who are only using Amarok for Onlineradio and Last.FM?
Comment 3 Sebastian Buch 2006-09-04 17:38:59 UTC 
I just removed the Disk and Amarok automatically removes the collection so the "Create Collection Database" is visable again.
Comment 4 Alexandre Oliveira 2006-09-04 17:41:01 UTC 
Changing the summary... Again...
Comment 5 Alexandre Oliveira 2006-09-07 01:16:27 UTC 
SVN commit 581650 by aoliveira:

Let the context browser work with streams, for people without any collection.
BUG: 133548


 M  +12 -8     contextbrowser.cpp  


--- trunk/extragear/multimedia/amarok/src/contextbrowser.cpp #581649:581650
@@ -1076,16 +1076,20 @@
     }
 
     // TODO: Show CurrentTrack or Lyric tab if they were selected
-    if ( m_emptyDB && CollectionDB::instance()->isValid() && !MountPointManager::instance()->collectionFolders().isEmpty() )
+    // If it's not a streaming, check for a collection
+    if ( !EngineController::engine()->isStream() )
     {
-        showScanning();
-        return;
+        if ( m_emptyDB && CollectionDB::instance()->isValid() && !MountPointManager::instance()->collectionFolders().isEmpty() )
+        {
+            showScanning();
+            return;
+        }
+        else if ( CollectionDB::instance()->isEmpty() || !CollectionDB::instance()->isValid() )
+        {
+            showIntroduction();
+            return;
+        }
     }
-    else if ( CollectionDB::instance()->isEmpty() || !CollectionDB::instance()->isValid() )
-    {
-        showIntroduction();
-        return;
-    }
     if( !m_dirtyCurrentTrackPage )
         return;
     m_currentURL = EngineController::instance()->bundle().url();