133159 – `ssget_extra' implicitly converted to pointer at icalssyacc.y:76

Bug 133159 - `ssget_extra' implicitly converted to pointer at icalssyacc.y:76

Summary: `ssget_extra' implicitly converted to pointer at icalssyacc.y:76

Status:	RESOLVED NOT A BUG

Alias:	None

Product:	korganizer
Classification:	Applications
Component:	general (show other bugs)
Version:	unspecified
Platform:	Compiled Sources Linux

Importance:	NOR normal
Target Milestone:	---
Assignee:	kdepim bugs

URL:
Keywords:

Depends on:
Blocks:

Reported:	2006-08-29 02:32 UTC by dann frazier
Modified:	2006-12-31 22:00 UTC (History)
CC List:	0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description dann frazier 2006-08-29 02:32:50 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (Debian 4.1.1-11) 
OS:                Linux

Our automated Debian buildd log filter[1] detected a problem that will cause
your package to segfault on architectures where the size of a pointer
is greater than the size of an integer, such as ia64 and amd64.

This is usually a sign of a missing function prototype.

I've verified that this issue exists with today's source snapshot (r577957).

This bug has existed in Debian for some time:
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347478

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions

Comment 1 Reinhold Kainhofer 2006-11-02 18:54:00 UTC

Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.

Comment 2 Reinhold Kainhofer 2006-12-31 21:29:51 UTC

That code is legacy code from libical, which is not used in KDE at all. We just copied the whole libical, as that was easier. However the code in question is never called from KOrganizer and libkcal.

So, I close this bug report as INVALID. I'll also try to remove as many unused files from our libical copy as possible...

Cheers,
Reinhold

Comment 3 Reinhold Kainhofer 2006-12-31 21:49:58 UTC

SVN commit 618271 by kainhofe:

Remove libical files from the libicalss/ subdir that were not used at all (but generated serious warnings in some distro's build systems... We only need icalclassify from libicalss, nothing else.

CCMAIL:133159@bugs.kde.org


 M  +0 -1      icalformatimpl.cpp  
 M  +0 -1      icalformatimpl.h  
 M  +4 -38     libical/src/libicalss/Makefile.am  
 D             libical/src/libicalss/icalcalendar.c  
 D             libical/src/libicalss/icalcalendar.h  
 M  +0 -51     libical/src/libicalss/icalclassify.c  
 M  +0 -6      libical/src/libicalss/icalclassify.h  
 D             libical/src/libicalss/icalcluster.c  
 D             libical/src/libicalss/icalcluster.h  
 D             libical/src/libicalss/icalclusterimpl.h  
 D             libical/src/libicalss/icaldirset.c  
 D             libical/src/libicalss/icaldirset.h  
 D             libical/src/libicalss/icaldirsetimpl.h  
 D             libical/src/libicalss/icalfileset.c  
 D             libical/src/libicalss/icalfileset.h  
 D             libical/src/libicalss/icalfilesetimpl.h  
 D             libical/src/libicalss/icalgauge.c  
 D             libical/src/libicalss/icalgauge.h  
 D             libical/src/libicalss/icalgaugeimpl.h  
 D             libical/src/libicalss/icalmessage.c  
 D             libical/src/libicalss/icalmessage.h  
 D             libical/src/libicalss/icalset.c  
 D             libical/src/libicalss/icalset.h  
 D             libical/src/libicalss/icalspanlist.c  
 D             libical/src/libicalss/icalspanlist.h  
 D             libical/src/libicalss/icalsslexer.c  
 D             libical/src/libicalss/icalsslexer.l  
 D             libical/src/libicalss/icalssyacc.c  
 D             libical/src/libicalss/icalssyacc.h  
 D             libical/src/libicalss/icalssyacc.y  


--- branches/KDE/3.5/kdepim/libkcal/icalformatimpl.cpp #618270:618271
@@ -31,7 +31,6 @@
 
 extern "C" {
   #include <ical.h>
-  #include <icalss.h>
   #include <icalparser.h>
   #include <icalrestriction.h>
 }
--- branches/KDE/3.5/kdepim/libkcal/icalformatimpl.h #618270:618271
@@ -31,7 +31,6 @@
 
 extern "C" {
   #include <ical.h>
-  #include <icalss.h>
 }
 
 namespace KCal {
--- branches/KDE/3.5/kdepim/libkcal/libical/src/libicalss/Makefile.am #618270:618271
@@ -8,45 +8,14 @@
 INCLUDES = -I../libical -I$(srcdir)/../libical
 
 libicalss_la_SOURCES =		\
-	icalcalendar.c		\
-	icalcalendar.h		\
 	icalclassify.c		\
-	icalclassify.h		\
-	icalcluster.c		\
-	icalcluster.h		\
-	icalclusterimpl.h	\
-	icalgauge.c		\
-	icalgauge.h		\
-	icalgaugeimpl.h		\
-	icaldirset.c		\
-	icaldirset.h		\
-	icaldirsetimpl.h	\
-	icalfileset.c		\
-	icalfileset.h		\
-	icalfilesetimpl.h	\
-	icalset.c		\
-	icalset.h		\
-	icalssyacc.h		\
-	icalspanlist.c		\
-	icalspanlist.h		\
-	icalmessage.c		\
-	icalmessage.h		\
-	icalsslexer.c           \
-        icalssyacc.c
+	icalclassify.h
 
 # We don't need icalss.h, but it needs to be built...
 libicalss_la_COMPILE_FIRST = ../libical/ical.h icalss.h
 
 COMBINEDHEADERS = \
-	$(srcdir)/icalgauge.h \
-	$(srcdir)/icalset.h \
-	$(srcdir)/icalcluster.h \
-	$(srcdir)/icalfileset.h \
-	$(srcdir)/icaldirset.h \
-	$(srcdir)/icalcalendar.h  \
-	$(srcdir)/icalclassify.h \
-	$(srcdir)/icalspanlist.h	\
-	$(srcdir)/icalmessage.h
+	$(srcdir)/icalclassify.h 
 
 icalss.h: $(COMBINEDHEADERS)
 	echo '#ifdef __cplusplus'	  >  icalss.h
@@ -63,10 +32,7 @@
 	echo '}'			  >> icalss.h
 	echo '#endif'			  >> icalss.h
 
-noinst_HEADERS = icalss.h icalcalendar.h icalclassify.h icalcluster.h \
-                 icaldirset.h icaldirsetimpl.h icalfileset.h icalfilesetimpl.h \
-                 icalgauge.h icalgaugeimpl.h icalmessage.h icalset.h \
-                 icalspanlist.h icalssyacc.h
+noinst_HEADERS = icalss.h icalclassify.h 
 
-CLEANFILES = y.output icalss.h
+CLEANFILES = icalss.h
 
--- branches/KDE/3.5/kdepim/libkcal/libical/src/libicalss/icalclassify.c #618270:618271
@@ -67,59 +67,8 @@
     return xnew;
 }
 
-/* Return a set of components that intersect in time with comp. For
-component X and Y to intersect:
-    X.DTSTART < Y.DTEND && X.DTEND > Y.DTSTART
-*/
 
 
-icalcomponent* icalclassify_find_overlaps(icalset* set, icalcomponent* comp)
-{
-    icalcomponent *return_set;
-    icalcomponent *c;
-    struct icaltime_span span,compspan;
-    
-    icalerror_clear_errno();
-    compspan = icalcomponent_get_span(comp);
-
-    if(icalerrno != ICAL_NO_ERROR){
-	return 0;
-    }
-
-
-    return_set = icalcomponent_new(ICAL_XROOT_COMPONENT);
-
-    for(c = icalset_get_first_component(set);
-	c != 0;
-	c = icalset_get_next_component(set)){
-
-	icalerror_clear_errno();
-
-	span = icalcomponent_get_span(c);
-
-	if(icalerrno != ICAL_NO_ERROR){
-	    continue;
-	}
-
-	if (compspan.start < span.end && 
-	    compspan.end > span.start){
-
-	    icalcomponent *clone = icalcomponent_new_clone(c);
-
-	    icalcomponent_add_component(return_set,clone);
-	}	
-    }
-
-    if(icalcomponent_count_components(return_set,ICAL_ANY_COMPONENT) !=0){
-	return return_set;
-    } else {
-	icalcomponent_free(return_set);
-	return 0;
-    }
-}
-
-
-
 icalproperty* icalclassify_find_attendee(icalcomponent *c, 
 						  const char* attendee)
 {
--- branches/KDE/3.5/kdepim/libkcal/libical/src/libicalss/icalclassify.h #618270:618271
@@ -27,16 +27,10 @@
 #define ICALCLASSIFY_H
 
 #include "ical.h"
-#include "icalset.h"
 
 icalproperty_xlicclass icalclassify(icalcomponent* c,icalcomponent* match, 
 			      const char* user);
 
-icalcomponent* icalclassify_find_overlaps(icalset* set, icalcomponent* comp);
-
-char* icalclassify_class_to_string(icalproperty_xlicclass c);
-
-
 #endif /* ICALCLASSIFY_H*/

Comment 4 Reinhold Kainhofer 2006-12-31 22:00:16 UTC

SVN commit 618273 by kainhofe:

Forward port of SVN commit 618271 by kainhofe:

Remove libical files from the libicalss/ subdir that were not used at all (but generated serious warnings in some distro's build systems... We only need icalclassify from libicalss, nothing else.

CCMAIL:133159@bugs.kde.org


 M  +0 -1      branches/work/kdepim-3.5.5+/libkcal/icalformatimpl.cpp  
 M  +0 -1      branches/work/kdepim-3.5.5+/libkcal/icalformatimpl.h  
 M  +4 -38     branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/Makefile.am  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalcalendar.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalcalendar.h  
 M  +0 -51     branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalclassify.c  
 M  +0 -6      branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalclassify.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalcluster.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalcluster.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalclusterimpl.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icaldirset.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icaldirset.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icaldirsetimpl.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalfileset.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalfileset.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalfilesetimpl.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalgauge.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalgauge.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalgaugeimpl.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalmessage.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalmessage.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalset.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalset.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalspanlist.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalspanlist.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalsslexer.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalsslexer.l  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalssyacc.c  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalssyacc.h  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalssyacc.y  
 D             branches/work/kdepim-3.5.5+/libkcal/libical/src/test (directory)  


--- branches/work/kdepim-3.5.5+/libkcal/icalformatimpl.cpp #618272:618273
@@ -31,7 +31,6 @@
 
 extern "C" {
   #include <ical.h>
-  #include <icalss.h>
   #include <icalparser.h>
   #include <icalrestriction.h>
 }
--- branches/work/kdepim-3.5.5+/libkcal/icalformatimpl.h #618272:618273
@@ -31,7 +31,6 @@
 
 extern "C" {
   #include <ical.h>
-  #include <icalss.h>
 }
 
 namespace KCal {
--- branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/Makefile.am #618272:618273
@@ -8,45 +8,14 @@
 INCLUDES = -I../libical -I$(srcdir)/../libical
 
 libicalss_la_SOURCES =		\
-	icalcalendar.c		\
-	icalcalendar.h		\
 	icalclassify.c		\
-	icalclassify.h		\
-	icalcluster.c		\
-	icalcluster.h		\
-	icalclusterimpl.h	\
-	icalgauge.c		\
-	icalgauge.h		\
-	icalgaugeimpl.h		\
-	icaldirset.c		\
-	icaldirset.h		\
-	icaldirsetimpl.h	\
-	icalfileset.c		\
-	icalfileset.h		\
-	icalfilesetimpl.h	\
-	icalset.c		\
-	icalset.h		\
-	icalssyacc.h		\
-	icalspanlist.c		\
-	icalspanlist.h		\
-	icalmessage.c		\
-	icalmessage.h		\
-	icalsslexer.c           \
-        icalssyacc.c
+	icalclassify.h
 
 # We don't need icalss.h, but it needs to be built...
 libicalss_la_COMPILE_FIRST = ../libical/ical.h icalss.h
 
 COMBINEDHEADERS = \
-	$(srcdir)/icalgauge.h \
-	$(srcdir)/icalset.h \
-	$(srcdir)/icalcluster.h \
-	$(srcdir)/icalfileset.h \
-	$(srcdir)/icaldirset.h \
-	$(srcdir)/icalcalendar.h  \
-	$(srcdir)/icalclassify.h \
-	$(srcdir)/icalspanlist.h	\
-	$(srcdir)/icalmessage.h
+	$(srcdir)/icalclassify.h 
 
 icalss.h: $(COMBINEDHEADERS)
 	echo '#ifdef __cplusplus'	  >  icalss.h
@@ -63,10 +32,7 @@
 	echo '}'			  >> icalss.h
 	echo '#endif'			  >> icalss.h
 
-noinst_HEADERS = icalss.h icalcalendar.h icalclassify.h icalcluster.h \
-                 icaldirset.h icaldirsetimpl.h icalfileset.h icalfilesetimpl.h \
-                 icalgauge.h icalgaugeimpl.h icalmessage.h icalset.h \
-                 icalspanlist.h icalssyacc.h
+noinst_HEADERS = icalss.h icalclassify.h 
 
-CLEANFILES = y.output icalss.h
+CLEANFILES = icalss.h
 
--- branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalclassify.c #618272:618273
@@ -67,59 +67,8 @@
     return xnew;
 }
 
-/* Return a set of components that intersect in time with comp. For
-component X and Y to intersect:
-    X.DTSTART < Y.DTEND && X.DTEND > Y.DTSTART
-*/
 
 
-icalcomponent* icalclassify_find_overlaps(icalset* set, icalcomponent* comp)
-{
-    icalcomponent *return_set;
-    icalcomponent *c;
-    struct icaltime_span span,compspan;
-    
-    icalerror_clear_errno();
-    compspan = icalcomponent_get_span(comp);
-
-    if(icalerrno != ICAL_NO_ERROR){
-	return 0;
-    }
-
-
-    return_set = icalcomponent_new(ICAL_XROOT_COMPONENT);
-
-    for(c = icalset_get_first_component(set);
-	c != 0;
-	c = icalset_get_next_component(set)){
-
-	icalerror_clear_errno();
-
-	span = icalcomponent_get_span(c);
-
-	if(icalerrno != ICAL_NO_ERROR){
-	    continue;
-	}
-
-	if (compspan.start < span.end && 
-	    compspan.end > span.start){
-
-	    icalcomponent *clone = icalcomponent_new_clone(c);
-
-	    icalcomponent_add_component(return_set,clone);
-	}	
-    }
-
-    if(icalcomponent_count_components(return_set,ICAL_ANY_COMPONENT) !=0){
-	return return_set;
-    } else {
-	icalcomponent_free(return_set);
-	return 0;
-    }
-}
-
-
-
 icalproperty* icalclassify_find_attendee(icalcomponent *c, 
 						  const char* attendee)
 {
--- branches/work/kdepim-3.5.5+/libkcal/libical/src/libicalss/icalclassify.h #618272:618273
@@ -27,16 +27,10 @@
 #define ICALCLASSIFY_H
 
 #include "ical.h"
-#include "icalset.h"
 
 icalproperty_xlicclass icalclassify(icalcomponent* c,icalcomponent* match, 
 			      const char* user);
 
-icalcomponent* icalclassify_find_overlaps(icalset* set, icalcomponent* comp);
-
-char* icalclassify_class_to_string(icalproperty_xlicclass c);
-
-
 #endif /* ICALCLASSIFY_H*/

Comment 5 Reinhold Kainhofer 2006-12-31 22:00:41 UTC

SVN commit 618274 by kainhofe:

Forward port of SVN commit 618271 by kainhofe:

Remove libical files from the libicalss/ subdir that were not used at all (but generated serious warnings in some distro's build systems... We only need icalclassify from libicalss, nothing else.

CCMAIL:133159@bugs.kde.org


 D             src/libicalss/icalcalendar.c  
 D             src/libicalss/icalcalendar.h  
 M  +0 -51     src/libicalss/icalclassify.c  
 M  +0 -6      src/libicalss/icalclassify.h  
 D             src/libicalss/icalcluster.c  
 D             src/libicalss/icalcluster.h  
 D             src/libicalss/icalclusterimpl.h  
 D             src/libicalss/icaldirset.c  
 D             src/libicalss/icaldirset.h  
 D             src/libicalss/icaldirsetimpl.h  
 D             src/libicalss/icalfileset.c  
 D             src/libicalss/icalfileset.h  
 D             src/libicalss/icalfilesetimpl.h  
 D             src/libicalss/icalgauge.c  
 D             src/libicalss/icalgauge.h  
 D             src/libicalss/icalgaugeimpl.h  
 D             src/libicalss/icalmessage.c  
 D             src/libicalss/icalmessage.h  
 D             src/libicalss/icalset.c  
 D             src/libicalss/icalset.h  
 D             src/libicalss/icalspanlist.c  
 D             src/libicalss/icalspanlist.h  
 D             src/libicalss/icalsslexer.c  
 D             src/libicalss/icalsslexer.l  
 D             src/libicalss/icalssyacc.c  
 D             src/libicalss/icalssyacc.h  
 D             src/libicalss/icalssyacc.y  
 D             src/test (directory)  
 D             test-data (directory)  


--- trunk/KDE/kdepimlibs/kcal/libical/src/libicalss/icalclassify.c #618273:618274
@@ -67,59 +67,8 @@
     return xnew;
 }
 
-/* Return a set of components that intersect in time with comp. For
-component X and Y to intersect:
-    X.DTSTART < Y.DTEND && X.DTEND > Y.DTSTART
-*/
 
 
-icalcomponent* icalclassify_find_overlaps(icalset* set, icalcomponent* comp)
-{
-    icalcomponent *return_set;
-    icalcomponent *c;
-    struct icaltime_span span,compspan;
-    
-    icalerror_clear_errno();
-    compspan = icalcomponent_get_span(comp);
-
-    if(icalerrno != ICAL_NO_ERROR){
-	return 0;
-    }
-
-
-    return_set = icalcomponent_new(ICAL_XROOT_COMPONENT);
-
-    for(c = icalset_get_first_component(set);
-	c != 0;
-	c = icalset_get_next_component(set)){
-
-	icalerror_clear_errno();
-
-	span = icalcomponent_get_span(c);
-
-	if(icalerrno != ICAL_NO_ERROR){
-	    continue;
-	}
-
-	if (compspan.start < span.end && 
-	    compspan.end > span.start){
-
-	    icalcomponent *clone = icalcomponent_new_clone(c);
-
-	    icalcomponent_add_component(return_set,clone);
-	}	
-    }
-
-    if(icalcomponent_count_components(return_set,ICAL_ANY_COMPONENT) !=0){
-	return return_set;
-    } else {
-	icalcomponent_free(return_set);
-	return 0;
-    }
-}
-
-
-
 icalproperty* icalclassify_find_attendee(icalcomponent *c, 
 						  const char* attendee)
 {
--- trunk/KDE/kdepimlibs/kcal/libical/src/libicalss/icalclassify.h #618273:618274
@@ -27,16 +27,10 @@
 #define ICALCLASSIFY_H
 
 #include "ical.h"
-#include "icalset.h"
 
 icalproperty_xlicclass icalclassify(icalcomponent* c,icalcomponent* match, 
 			      const char* user);
 
-icalcomponent* icalclassify_find_overlaps(icalset* set, icalcomponent* comp);
-
-char* icalclassify_class_to_string(icalproperty_xlicclass c);
-
-
 #endif /* ICALCLASSIFY_H*/