Bug 133073 - toolbar icon for lockzoom is always displayed in size 22x22
Summary: toolbar icon for lockzoom is always displayed in size 22x22
Status: RESOLVED WORKSFORME
Alias: None
Product: kooka
Classification: Applications
Component: general (show other bugs)
Version: 0.44
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Jonathan Marten
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-27 14:46 UTC by Janet
Modified: 2010-11-05 12:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
screeenshots of kooka toolbar lockzoom icon (18.74 KB, image/jpeg)
2006-08-27 14:48 UTC, Janet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Janet 2006-08-27 14:46:37 UTC
Version:           0.44 (using KDE 3.5.4, Debian Package 4:3.5.4-3 (testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17.9-slh-smp-1

I always kept the kooka toolbar in size 22x22 because the icons provided only are in 22x22 and would be ugly scaled on a 32x32 toolbar. But now I pulled myself together and made some 32x32 icons - and realized that they go fine with one exception: the lockzoom.png icon always is displayed in size 22x22, no matter in which sizes the icon is available and no matter which size the toolbar has. I admit it is a very small gui bug but nonetheless it is a bug.
Comment 1 Janet 2006-08-27 14:48:37 UTC
Created attachment 17519 [details]
screeenshots of kooka toolbar lockzoom icon

I made two toolbar screenshots, size 16x16 and 32x32. You can see the lockzoom
icon in both cases is 22x22.
Comment 2 Jonathan Marten 2008-03-19 20:40:28 UTC
This icon (uniquely) is specified using BarIcon() which forces the icon size.  Removing that would allow the icon size to adjust in the same way as all the others:

--- kooka.cpp   (revision 784536)
+++ kooka.cpp   (working copy)
@@ -159,7 +162,7 @@ void Kooka::setupActions()
     KAction *act = new KToggleAction ( i18n("Keep Zoom Setting"), lockSet, CTRL+Key_Z,
                                       actionCollection(), "keepZoom" );
#else
-    KAction *act = new KToggleAction( i18n("Keep Zoom Setting"), BarIcon("lockzoom"), CTRL+Key_Z,
+    KAction *act = new KToggleAction( i18n("Keep Zoom Setting"), "lockzoom", CTRL+Key_Z,
                                      actionCollection(), "keepZoom" );
#endif
Comment 3 Jonathan Marten 2008-03-27 11:20:23 UTC
SVN commit 790731 by marten:

Big reorganisation of OCR stuff, hopefully making it easier to
add new OCR engines in future.  The base OCR engine support and the
OCR dialogue are now abstract classes, subclassed by the 3 supported
OCR engines.

Correctly save OCR spell checking options, bug 141927
New action to manually do the OCR result spell check
No need to restart Kooka after changing OCR engine
Show a preview and image information when using "OCR Selection"
Restore labels on GOCR parameter sliders

Other fixes:

Hide the rarely used "Enable all messages..." action away in preferences dialogue
Correctly load startup image if path to gallery or $HOME contains a symlink
Correct fixed size of "lockzoom" toolbar icon, bug 133073
Use correct debug areas: kooka=28000, libkscan=29000

CCBUG:141927
CCBUG:133073



 M  +11 -8     Makefile.am  
 M  +1 -1      formatdialog.cpp  
 M  +2 -2      imgsaver.cpp  
 D             kocrbase.cpp  
 D             kocrbase.h  
 D             kocrgocr.cpp  
 D             kocrgocr.h  
 D             kocrkadmos.cpp  
 D             kocrkadmos.h  
 D             kocrocrad.cpp  
 D             kocrocrad.h  
 M  +96 -69    kooka.cpp  
 M  +3 -5      kooka.h  
 M  +1 -1      kookaimage.cpp  
 M  +1 -1      kookaimage.h  
 M  +64 -49    kookapref.cpp  
 M  +14 -10    kookapref.h  
 M  +2 -2      kookaui.rc  
 M  +103 -75   kookaview.cpp  
 M  +6 -2      kookaview.h  
 D             ksaneocr.cpp  
 D             ksaneocr.h  
 M  +1 -1      main.cpp  
 A             ocrbasedialog.cpp   kocrbase.cpp#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrbasedialog.h   kocrbase.h#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrengine.cpp   ksaneocr.cpp#781253 [License: GPL (v2) (+Qt exception)]
 A             ocrengine.h   ksaneocr.h#781253 [License: GPL (v2) (+Qt exception)]
 A             ocrgocrdialog.cpp   kocrgocr.cpp#784536 [License: GPL (v2) (+Qt exception)]
 A             ocrgocrdialog.h   kocrgocr.h#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrgocrengine.cpp   [License: GPL (v2) (+Qt exception)]
 A             ocrgocrengine.h   [License: GPL (v2) (+Qt exception)]
 A             ocrkadmosdialog.cpp   kocrkadmos.cpp#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrkadmosdialog.h   kocrkadmos.h#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrkadmosengine.cpp   [License: GPL (v2) (+Qt exception)]
 A             ocrkadmosengine.h   [License: GPL (v2) (+Qt exception)]
 A             ocrocraddialog.cpp   kocrocrad.cpp#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrocraddialog.h   kocrocrad.h#774594 [License: GPL (v2) (+Qt exception)]
 A             ocrocradengine.cpp   [License: GPL (v2) (+Qt exception)]
 A             ocrocradengine.h   [License: GPL (v2) (+Qt exception)]
 M  +85 -85    scanpackager.cpp  
 M  +2 -3      scanpackager.h  
 M  +10 -10    scanparamsdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=790731