Bug 133013 - Pause does still work when playing last.fm streams
Summary: Pause does still work when playing last.fm streams
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.0-SVN
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-26 09:52 UTC by Elias Probst
Modified: 2008-07-10 11:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2006-08-26 09:52:02 UTC 
Version:           1.4.2 (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages

When playing a Last.fm stream, the pause button is greyed out. But "internal", pause still works (when using dcop, the Mediacontrol Kicker applet, the keyboard shortcut for "pause", ...).
Please fix this, as I often accidentally push "Meta+C" or the pause button at the Mediacontrol Kicker applet while playing a Last.fm stream.
Comment 1 Seb Ruiz 2006-11-15 02:20:21 UTC 
SVN commit 605024 by seb:

Forbid pausing the engine when using lastfm. Now pause can't be issued from dcop or shortcuts.
BUG: 133013


 M  +1 -1      enginecontroller.cpp  


--- trunk/extragear/multimedia/amarok/src/enginecontroller.cpp #605023:605024
@@ -493,7 +493,7 @@
 
 void EngineController::pause() //SLOT
 {
-    if ( m_engine->loaded() )
+    if ( m_engine->loaded() && !LastFm::Controller::instance()->isPlaying() )
         m_engine->pause();
 }
Comment 2 Elias Probst 2008-06-17 21:29:59 UTC 
Affects now Amarok 2.x.
Comment 3 Mark Kretschmann 2008-07-10 11:50:40 UTC 
In Amarok 2 it is now actually possible to pause and resume Last.fm streams without problems :)