Bug 132818 - Kontact/KOrganizer produces non-standard iCalendar .ics
Summary: Kontact/KOrganizer produces non-standard iCalendar .ics
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-22 19:48 UTC by Andrew Ziem
Modified: 2011-01-01 21:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Ziem 2006-08-22 19:48:13 UTC
Version:            (using KDE KDE 3.5.4)
Installed from:    Fedora RPMs

Someone with Mozilla Calendar suggested that Kontact produces a non-standard iCal .ics in regards to the VALARM.  

Details here:
https://bugzilla.mozilla.org/show_bug.cgi?id=349715#c2

Sample file here:
https://bugzilla.mozilla.org/show_bug.cgi?id=349715#c1
Comment 1 Reinhold Kainhofer 2006-11-02 18:56:25 UTC
Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.
Comment 2 Maximilian Michel 2006-11-02 18:59:21 UTC
Recently (in nightly builds) sunbird was patched to accept Kontact-non-standard iCal files.
Comment 3 Sergio Martins 2009-01-08 07:48:48 UTC
Are there any good validators?

This one http://severinghaus.org/projects/icv/ says the sample file is compliant.
Comment 4 Sergio Martins 2009-03-01 22:54:32 UTC
Currently libkcal only supports reminders relative to due date. It doesn't matter if you select "Before Start" in the dialog, it will be relative to due date. 

BUT it's always written to the ical file as being relative to dtStart.

Things to do:
--------------
1. koeditoralarms.cpp: Only present After Start/Before Start options if there's a dtStart and only present After End/Before End if there's a dtDue.

2. koincidenceeditor.cpp: Currently you can't sent reminders on to-dos which don't have dtDue, this protection should be removed, only the case where both dtDue and dtStart is missing should me preserved.

3. KCal's alarm.cpp: Change time() function so it respects  d->mEndOffset/ d->mStartOffset
Comment 5 Sergio Martins 2009-03-02 01:02:55 UTC
Please forget this part:

"BUT it's always written to the ical file as being relative to dtStart."

It writes whatever you choose in the alarm editor.
Comment 6 Sergio Martins 2009-03-02 01:12:13 UTC
SVN commit 933949 by smartins:

Support for alarms relative to to-do's dtStart().

CCBUG: 132818


 M  +9 -3      alarm.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=933949
Comment 7 Sergio Martins 2009-03-02 01:20:57 UTC
Ok, now if you open an .ical file from another organizer, korgac will do the right thing for a to-do reminder relative to start.

We still need to protect against invalid combinations in the editor so we don't get non-standard .ics files.
Comment 8 Sergio Martins 2011-01-01 21:51:00 UTC
The new incidence editors validate invalid combinations now.