Bug 131958 - konversation disregards "Follow nick changes" when DCC chat conversations take place
Summary: konversation disregards "Follow nick changes" when DCC chat conversations tak...
Status: RESOLVED INTENTIONAL
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-06 17:14 UTC by Niek Beernink
Modified: 2006-08-20 17:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niek Beernink 2006-08-06 17:14:03 UTC
Version:           revision 570312 (using KDE KDE 3.5.4)
Compiler:          gcc (GCC) 4.1.2 20060715 (prerelease) (Ubuntu 4.1.1-9ubuntu1)  
OS:                Linux

If you're talking to a person in a /query window, and then type /dcc chat nick, konversation creates an additional logfile with the person's name between dashes, so $server_-$nick-.log if you then look in the logs directory, you've got two log files for the same person. $server_$nick.log and $server_-$nick-.log

If the person you're chatting with changes his nickname while you're having a DCC chat conversation, the nick in the channel updates, but the one in the DCC chat tab does not. And when you then close and reopen the /query window, another log file is added for the changed nickname. 

I also noticed that /query conversation log files are being lower-cased, whereas DCC chat conversations are not.
I suggest picking one style and sticking with it.

So... to reproduce;

1. Enable "Follow nick changes".
2. Open query with someone. (by typing /query $nickname)
3. Exchange some messages. 
4. Notice the log file being created. ($server_$nickname.log)
5. Open a DCC chat window with that person. (by typing /dcc chat $nickname)
6. Exchange some messages.
7. Notice a second log file being created. ($server_-$nickname-.log)
8. Close the query window.
9. Have the other user change his nickname.
10. Notice the nickname changing in the channel and the one on the DCC chat tab staying the same.
11. Open a /query with the person again.
12. Exchange some messages.
13. Notice how a third log file is created. ($server_$changednickname.log)

Expected behavior;

I expect konversation to disregard the fact that I'm having a DCC chat konversation with the user. It should create 1 log file and use that for both types of conversation methods.
Comment 1 Eike Hein 2006-08-19 23:59:36 UTC
IMO, this is a WONTFIX. In a technical sense, a DCC Chat once started is decoupled from a specific server connection, i.e. when you start a DCC chat with someone and on the IRC server that someone leaves and is replaced with a different person who happens to occupy the same nick, the DCC Chat is entirely unaffected. It's not a query. And shouldn't track nick changes that don't affect it.
Comment 2 Eike Hein 2006-08-20 17:33:01 UTC
Addendum: We've pretty much reached a consensus now that tracking nick changes for DCC chats doesn't make sense. 

However, this report also confuses the issue, which makes it a bit messy to deal with. Following nick changes to reuse the same logfile presently only happens for the duration of a query being open, i.e. a new query will be started with the then-current nickname and a logfile with that nickname be created.
Comment 3 Eike Hein 2006-08-20 17:51:16 UTC
Close this as WONTFIX as pertaining to the report title.