Bug 131951 - "XXX has ended their participation in the chat session" should not generate flash in system tray
Summary: "XXX has ended their participation in the chat session" should not generate f...
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Jabber Plugin (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-06 12:35 UTC by Dawid Ciężarkiewicz
Modified: 2006-08-07 16:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Ciężarkiewicz 2006-08-06 12:35:24 UTC
Version:            (using KDE KDE 3.5.4)

In chat:

I'm saying "ok, back to work, cu" and close the window, then other side closes his/her window and "XXX has ended their participation in the chat session" makes my try flashing only because of that info. Little annoying.
Comment 1 Olivier Goffart 2006-08-07 16:49:18 UTC
SVN commit 570654 by ogoffart:

doesn't flash taskbar or show a bubble for the 'gone' notification
BUG: 131951

 M  +2 -1      jabbercontact.cpp  


--- branches/kopete/0.12/kopete/protocols/jabber/jabbercontact.cpp #570653:570654
@@ -301,7 +301,8 @@
 					Kopete::Message m=Kopete::Message ( this, mManager->members(),
 						i18n("%1 has ended their participation in the chat session.").arg(metaContact()->displayName()),
 						Kopete::Message::Internal  );
-					mManager->appendMessage ( m, message.from().resource () );
+					m.setImportance(Kopete::Message::Low);
+					mManager->view()->appendMessage ( m ); //use KopeteView::AppendMessage to bypass notifications
 				}
 			}
 		}