Bug 131869 - History plugin text colour not used when disabling user specified rich text and font foreground colour
Summary: History plugin text colour not used when disabling user specified rich text a...
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Chat Window (show other bugs)
Version: 0.12.6
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-04 17:57 UTC by Mike McQuaid
Modified: 2008-01-19 21:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike McQuaid 2006-08-04 17:57:35 UTC
Version:           0.12 (using KDE KDE 3.5.4)
Installed from:    Ubuntu Packages
OS:                Linux

Loaded plugins:
History plugin (required to reproduce)

How to reproduce:
1) Enable the history plugin, if you haven't already.
2) Select Configure from the Settings menu
3) Appearance > Colours and Fonts > and check "Do not show user specified rich text" AND "Do not show user specified foreground colour".
4) Open a new window to a contact, that should display history.
5) Observe that the history text is no longer the colour specified in the history plugin.

This isn't a Kubuntu problem, as it has been confirmed by hrw from #kopete on freenode on a Debian system. It applies to 0.12, 0.12.1 and 0.12.2, and may well also apply to prior versions.
Comment 1 Mike McQuaid 2006-09-06 17:32:23 UTC
No confirmation?
Comment 2 Alistair Strachan 2006-09-06 17:42:26 UTC
Definitely works in 0.11.3 in KDE 3.5.4, so I can only assume this is a regression.
Comment 3 Dylan Griffiths 2006-09-08 10:14:28 UTC
I found the same bug.  Basically, I had the font set to white, and the bgcolour set to black.  The history plugin takes my pref for the foreground colour (= white), and ignores the background colour (and picks white).  White on white text.  Gee, thanks :p

Someone needs to go into the init routine and grab the user preference colour instead of using a default value (the way the correctly do for the user foreground colour).

I had enabled don't show user specified bgcolour/fgcolour/rich text for incoming messages, which should not affect the history plugin (IMO).  If they do, the code should be like this:

For each message to add to the history list view:
If Message from host
 - Use host colour
If Message from remote
 - If NOT use remote colour, use host colours.
 - Else print w/ saved colours.

It's not hard :/
Comment 4 Will Stephenson 2007-11-14 17:02:19 UTC
Works in trunk, broken in 0.12.6
Comment 5 Diwaker Gupta 2008-01-19 21:33:39 UTC
I can confirm this bug on Kubuntu Gutsy 7.10, KDE/Kopete 3.5.8
Comment 6 Diwaker Gupta 2008-01-19 21:34:57 UTC
I should mention Kubuntu Gutsy 7.10 ships with Kopete 0.12.7