Bug 131718 - ICQ authorization request pops up at every login
Summary: ICQ authorization request pops up at every login
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: ICQ and AIM Plugins (other bugs)
Version First Reported In: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Roman Jarosz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-02 12:23 UTC by Christian Banik
Modified: 2006-08-26 21:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
debug log of kopete (273.66 KB, text/plain)
2006-08-04 22:21 UTC, Christian Banik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Banik 2006-08-02 12:23:44 UTC
Version:           0.12.1 (using KDE 3.5.2, Gentoo)
Compiler:          gcc version 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9)
OS:                Linux (i686) release 2.6.17-suspend2-r3

When I start kopete, an authorization request from another user pops up. No matter whether I authorize or deny it, it pops up again the next time I start kopete.
Comment 1 Roman Jarosz 2006-08-04 21:26:20 UTC
I need more info to solve it. Please compile kopete with debug USE flag and post a console log. I need log when you receive the authorization request and than you authorize/deny it.

If you don't want to post it here mail it to me.
Comment 2 Christian Banik 2006-08-04 22:21:50 UTC
Created attachment 17230 [details]
debug log of kopete

Here's the debug log. I have added some marks in the file which all start with
"---".
Comment 3 Roman Jarosz 2006-08-04 22:55:34 UTC
Can you also tell me what ICQ client and version does the contact use?
Comment 4 Christian Banik 2006-08-05 01:03:11 UTC
One of the contacts told me he's using Trillian Pro 3 - AIM & ICQ 3.0 by Cerullean Studios. About the other one I have no idea.
Comment 5 Roman Jarosz 2006-08-05 11:34:12 UTC
I can't reproduce this with Trillian, authorization works great here.

The log shows that icq server sends kopete authorization request.
If it's on every login than the other client must request authorization every time you login or icq server is somehow broken.

Can you use official or www(go.icq.com) client to see if the authorization request popups there on every login too, and if you can authorize it there.
Comment 6 Christian Banik 2006-08-05 12:41:51 UTC
Strange...

whenever I opened kopete today, I got kicked out of the ICQ network.

When I started ICQ2Go, these authorization request messages didn't come up. Afterwards I started kopete again, and these messages don't show up anymore (and the ICQ network accepts my client again). Looks like it's resolved.

Thanks a lot for your help!
Comment 7 fbayer 2006-08-21 16:47:21 UTC
I still have the problem with kopete 0.12.1 (kde 3.5.4 - kubuntu)! 
 it does not matter which client the other chat partner owns. 
 
 maybe it has something to do with the option to enable/disable require authorization. because for me i disabled the need for authorization but the message though appears. 
 
 i asked the other contact .. and he says he is authorized. so the problem is only that thedialog till appears.. not that he is not authorized. 
 
 when i once log in into icq with another client (e.g. go.icq.com or trillian) the contact is authorized/the message does not appear anymore. 
 
 -> please reopen the bug! 
 
Comment 8 Roman Jarosz 2006-08-26 12:38:16 UTC
I can reproduce it, reopening.
Comment 9 Roman Jarosz 2006-08-26 21:47:58 UTC
SVN commit 577478 by rjarosz:

Fix bug 131718 ICQ authorization request pops up at every login.

Always delete offline messages from server because authorization request is also treated as an offline message.
Official ICQ client deletes offline messages always too.

BUG: 131718



 M  +1 -5      offlinemessagestask.cpp  
 M  +0 -1      offlinemessagestask.h  


--- branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/liboscar/offlinemessagestask.cpp #577477:577478
@@ -30,7 +30,6 @@
  : ICQTask( parent )
 {
 	tzset();
-	m_msgCount = 0;
 	m_sequence = 0;
 }
 
@@ -133,8 +132,6 @@
 	
 	kdDebug( OSCAR_RAW_DEBUG ) << k_funcinfo << "Received offline message '" << msg.data() << "' from " << senderUin << endl;
 	
-	m_msgCount++;
-	
 	emit receivedOfflineMessage( message );
 }
 
@@ -148,8 +145,7 @@
 	buffer->skipBytes( 8 );
 	m_sequence = buffer->getLEWord();
 	
-	if ( m_msgCount > 0 )
-		deleteOfflineMessages();
+	deleteOfflineMessages();
 	
 	setSuccess( true );
 }
--- branches/KDE/3.5/kdenetwork/kopete/protocols/oscar/liboscar/offlinemessagestask.h #577477:577478
@@ -48,7 +48,6 @@
 	void deleteOfflineMessages();
 	
 private:
-	int m_msgCount;
 	int m_sequence;
 };