Bug 131223 - "Upcoming Tracks" in dynamic playlist should be able to be set to 0
Summary: "Upcoming Tracks" in dynamic playlist should be able to be set to 0
Status: RESOLVED UNMAINTAINED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.4.1
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-22 23:41 UTC by Dave Baker
Modified: 2009-08-03 04:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Baker 2006-07-22 23:41:45 UTC
Version:           1.4.1 (using KDE KDE 3.5.3)
Installed from:    Gentoo Packages
Compiler:          gcc (GCC) 4.1.1 (Gentoo 4.1.1)
 
OS:                Linux

Would it be possible for "Upcoming Tracks" for a dynamic playlist to be set to 0? Seeing what's coming up is great for a party, in other circumstances I don't want to know what's next. It would also be good to still be able to skip forward to the next track (ie. select a new one) using the next track button.
Comment 1 Seb Ruiz 2006-07-23 11:01:16 UTC
This won't work due to the way that Amarok is designed.  Since adding to the playlist is threaded, the playlist would think that the playlist is finished and stop playing, then add a new song to the end.
Comment 2 Dave Baker 2006-07-23 13:02:03 UTC
Really? Oh. I can get the desired behaviour by loading a single track, then loading a dynamic playlist, then pressing 'play'. Once it's played that song it adds another one and plays that. It crashes quite frequently though. This used to be okay when 'stop' followed by 'play' would stop playing the current track and play a new one, but in 1.4.1 it just starts playing the track I just stopped again.
Comment 3 Dave Baker 2006-07-31 00:57:52 UTC
I can confirm that this is definitely possible. I'm using it right now. The behaviour can be produced by turning on a dynamic playlist, dragging a single file to the playlist and pressing 'play'. When the track finishes, another track is added to the playlist and played. The shortcut key (win+B) even works to skip to the next track (ie add a new one and play it) even though the 'next' button is disabled!

So really, this does fundamentally work, so it seems obvious to allow it to be accessed the proper way by allowing 'Upcoming Tracks' to be set to zero, and not disabling the next button if playing the last track and a dynamic playlist is turned on.
Comment 4 Seb Ruiz 2006-08-31 02:40:09 UTC
SVN commit 579071 by seb:

* Remove the option to enable/disable history in dynamic mode. It is now on always.
* Disable "Played tracks to show" option if tracks are not removed from dynamic mode, when creating a new dynamic playlist
* Reduce the minimum available tracks to show to 0.
* The beginnings of restoring purged items for podcasts (got caught up in the commit).

BUG: 133078
BUG: 133076
BUG: 131223



 M  +2 -0      ChangeLog  
 M  +0 -3      src/dynamicmode.cpp  
 M  +0 -3      src/dynamicmode.h  
 M  +25 -35    src/newdynamic.ui  
 M  +24 -30    src/playlist.cpp  
 M  +1 -1      src/playlist.h  
 M  +0 -4      src/playlistbrowser.cpp  
 M  +50 -11    src/playlistbrowseritem.cpp  
 M  +1 -0      src/playlistbrowseritem.h  
 M  +0 -2      src/playlistselection.cpp  
Comment 5 bonne 2007-01-29 01:17:11 UTC
Has this been reverted? 
Comment 6 Dave Baker 2007-06-27 10:57:39 UTC
This has now regressed and no longer works in 1.4 HEAD. The last working version I have unfortunately is from 1.4 head as of the 17th of April (ie. I've just done svn merge -r HEAD:{2007-04-17} . and I now have working version back again). I can't be more specific about when the regression occurred yet, but if I get a chance to investigate I'll post more info here.

The behaviour now is, with upcoming tracks set to zero, it does add another track to the playlist as I'd expect, but doesn't play it. If I then add another track manually it will start playing immediately.
Comment 7 Matt Rogers 2009-08-03 04:03:28 UTC
Thank you for taking the time to report this bug for Amarok. Amarok 1.4 is now unmaintained and will no longer see any improvements. Because of this, and the massive amount of changes Amarok has undergone throughout the 2.x series of releases, we are closing bugs that no longer apply to the 2.x series due to changes in functionality, the underlying architecture, or a conflict for the vision of Amarok 2.

We appreciate the time you took to provide feedback about Amarok 1.4 and will look forward to any feedback you may provided about Amarok 2. Thanks.