Bug 131005 - timezone handling fails on some systems
Summary: timezone handling fails on some systems
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: NetBSD pkgsrc NetBSD
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-18 02:40 UTC by Mark Davies
Modified: 2007-07-26 17:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
patch to use KTimezones class (3.47 KB, patch)
2006-07-18 02:41 UTC, Mark Davies 		Details
patch to use KTimezones class (847 bytes, patch)
2006-07-18 02:43 UTC, Mark Davies 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Davies 2006-07-18 02:40:21 UTC 
Version:            (using KDE KDE 3.5.3)
Installed from:    NetBSD pkgsrc
Compiler:          gcc 3.3.4 
OS:                NetBSD

korganiser tries to handle timezones itself and doesn't handle very well different systems that may have /etc/timezone vs /etc/localtime vs TZ environment variable vs something else and different locations for the zone.tab file resulting in just "[No Selection]" in the Timezone list in the Time and Date configure panel or not matching the local time zone against one in the list.  As is seen in Bug #40541 (where a Solaris specific patch has been applied) and Bug #88636 which is still outstanding.
For a while now kdelibs has had a KTimezones class that deals with all this for you.  I will attach two patches to this bug report that change korganiser to use that class.  They are functional but someone with better CC++ knowledge than mine could clean up the patches.  I just kept them that way to make minimal changes to the surrounding code.

cheers
mark
Comment 1 Mark Davies 2006-07-18 02:41:55 UTC 
Created attachment 17018 [details]
patch to use KTimezones class
Comment 2 Mark Davies 2006-07-18 02:43:18 UTC 
Created attachment 17019 [details]
patch to use KTimezones class
Comment 3 Reinhold Kainhofer 2006-11-02 19:09:29 UTC 
Reassigning all KOrganizer bug reports and wishes to the newly created 
korganizer-devel mailing list.
Comment 4 Bruno Virlet 2007-07-26 17:59:43 UTC 
This is fixed in KDE4, it uses kdelibs which has all the platform-dependant code.