Bug 130883 - overexposure indicator in color management is saved as part of the picture
Summary: overexposure indicator in color management is saved as part of the picture
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Canvas (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-16 00:56 UTC by Erik van der Velden
Modified: 2017-08-08 08:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik van der Velden 2006-07-16 00:56:12 UTC
Version:           9.0 svn (using KDE KDE 3.5.3)
Installed from:    Gentoo Packages
Compiler:          x86_64-pc-linux-gnu-3.4.6 
OS:                Linux

When using the color management (fix->colors->color management) with the new 'over exposure' indicator, the over exposed part of the picture are hightlighted in nice bright colors.
However, when you click on OK, picture is saved as it is at that moment on the screen, i.e., with the overexposed parts still indicated by bright colors.

It can easily reproduced by using the lightness adjustments to brighten the figure considerably.
Comment 1 caulier.gilles 2006-07-16 09:02:39 UTC
SVN commit 562893 by cgilles:

digiKam from trunk : Color Management image plugin : fix over exposure rule with final rendering

BUG: 130883



 M  +2 -1      NEWS  
 M  +2 -2      imageplugins/imageeffect_iccproof.cpp  


--- trunk/extragear/graphics/digikam/NEWS #562892:562893
@@ -166,6 +166,7 @@
 103 ==> 126199 : Nikon D70 comments in jpegs are all shown as "charset="Ascii".
 104 ==> 130381 : Automatic colorbalance and camera color balance checkboxes swapped.
 105 ==> 117248 : Opening default app when camera inserted return KIOExec error.
-106 ==> 
+106 ==> 130883 : Overexposure indicator in color management is saved as part of the picture
+107 ==> 
 
 ----------------------------------------------------------------------------------------------------
--- trunk/extragear/graphics/digikam/imageplugins/imageeffect_iccproof.cpp #562892:562893
@@ -1018,8 +1018,7 @@
             //-- Calculate and apply the curve on image after transformation -------------
         
             Digikam::DImg img2(w, h, sb, a, 0, false);
-            m_curves->curvesLutSetup(Digikam::ImageHistogram::AlphaChannel,
-                                     m_overExposureIndicatorBox->isChecked());
+            m_curves->curvesLutSetup(Digikam::ImageHistogram::AlphaChannel, false);
             m_curves->curvesLutProcess(img.bits(), img2.bits(), w, h);
         
             //-- Adjust contrast ---------------------------------------------------------
@@ -1124,6 +1123,7 @@
         KMessageBox::error(this, i18n("Sorry, it seems there is no embedded profile"), i18n("Profile Error"));
         return;
     }
+
     QString intent;
     cmsHPROFILE selectedProfile = cmsOpenProfileFromMem(profile.data(), (DWORD)profile.size());
     QString profileName         = QString((cmsTakeProductName(selectedProfile)));