Bug 130517 - Amarok doesn't build with tunepimp 0.5
Summary: Amarok doesn't build with tunepimp 0.5
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-09 16:18 UTC by Malte S. Stretz
Modified: 2006-08-07 22:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2006-07-09 16:18:32 UTC
Version:           unknown (using KDE 3.5.3, Gentoo)
Compiler:          gcc version 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9)
OS:                Linux (i686) release 2.6.16-gentoo-r9-bug5964-try2

It seems like the support for TRMs was changed or even removed from tunepimp 0.5 (needed for Picard 0.7).  Amarok fails to build with the following error:

/bin/sh ../../libtool --silent --mode=compile --tag=CXX i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I../../amarok/src/amarokcore -I../../amarok/src/amarokcore -I../../amarok/src/analyzers -I../../amarok/src/plugin -I../../amarok/src/statusbar -I../../amarok/src/mediadevice -I../../amarok/src -I/usr/kde/3.5/include/arts -I/usr/include/taglib -I../../amarok/src/sqlite -I/usr/include/mysql -pipe -march=athlon-tbird -DHAVE_ERRNO_AS_DEFINE=1   -I/usr/kde/3.5/include -I/usr/qt/3/include -I.  -I/usr/kde/3.5/include  -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -g3 -fno-inline -pipe -march=athlon-tbird -O2 -fno-inline -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION  -c -o kbookmarkhandler.lo `test -f 'kbookmarkhandler.cpp' || echo './'`kbookmarkhandler.cpp
/usr/qt/3/bin/moc ./ktrm.h -o ktrm.moc
/bin/sh ../../libtool --silent --mode=compile --tag=CXX i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I../../amarok/src/amarokcore -I../../amarok/src/amarokcore -I../../amarok/src/analyzers -I../../amarok/src/plugin -I../../amarok/src/statusbar -I../../amarok/src/mediadevice -I../../amarok/src -I/usr/kde/3.5/include/arts -I/usr/include/taglib -I../../amarok/src/sqlite -I/usr/include/mysql -pipe -march=athlon-tbird -DHAVE_ERRNO_AS_DEFINE=1   -I/usr/kde/3.5/include -I/usr/qt/3/include -I.  -I/usr/kde/3.5/include  -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -g3 -fno-inline -pipe -march=athlon-tbird -O2 -fno-inline -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION  -c -o ktrm.lo `test -f 'ktrm.cpp' || echo './'`ktrm.cpp
ktrm.cpp: In constructor `KTRMRequestHandler::KTRMRequestHandler()':
ktrm.cpp:132: error: `tp_SetTRMCollisionThreshold' was not declared in this scope
ktrm.cpp:134: error: `tp_SetAutoFileLookup' was not declared in this scope
ktrm.cpp:132: warning: unused variable 'tp_SetTRMCollisionThreshold'
ktrm.cpp:134: warning: unused variable 'tp_SetAutoFileLookup'
ktrm.cpp: In function `void TRMNotifyCallback(void*, void*, TPCallbackEnum, int, TPFileStatus)':
ktrm.cpp:292: error: `eTRMCollision' was not declared in this scope
ktrm.cpp:292: warning: unused variable 'eTRMCollision'
ktrm.cpp: In member function `virtual void KTRMLookup::unrecognized()':
ktrm.cpp:564: error: `tr_GetTRM' was not declared in this scope
ktrm.cpp:564: warning: unused variable 'tr_GetTRM'
ktrm.cpp: In member function `virtual void KTRMLookup::collision()':
ktrm.cpp:596: error: `tr_GetNumResults' was not declared in this scope
ktrm.cpp:609: error: `tr_GetResults' was not declared in this scope
ktrm.cpp:609: warning: unused variable 'tr_GetResults'
ktrm.cpp:596: warning: unused variable 'tr_GetNumResults'
make[4]: *** [ktrm.lo] Error 1
make[4]: Leaving directory `/var/tmp/portage/amarok-1.4.1-r1/work/amarok-1.4.1/amarok/src'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/amarok-1.4.1-r1/work/amarok-1.4.1/amarok/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/amarok-1.4.1-r1/work/amarok-1.4.1/amarok'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/amarok-1.4.1-r1/work/amarok-1.4.1'
make: *** [all] Error 2

There doesn't seem to be any 0.5 documentation on the MB website yet, but I tried the MB/picard overlay for Gentoo available here <http://juffo.org/proj/musicbrainz-overlay/README.html>.
Comment 1 Alexandre Oliveira 2006-08-07 22:34:47 UTC
SVN commit 570541 by aoliveira:

Actually support tunepimp 0.5.0 final. Years are broken (always empty) when using 0.5.0, but I'll leave it as it is for now unless
MusicBrainz change their XML WebService. Otherwise, we'd need an extra lookup to get the year for each possible release (some
tracks show me 7 releases), which is not an option.


 M  +4 -2      configure.in.in
 M  +118 -10   src/ktrm.cpp
 M  +12 -0     src/ktrm.h