Bug 130381 - automatic colorbalance and camera color balance checkboxes swapped
Summary: automatic colorbalance and camera color balance checkboxes swapped
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Setup-ImageEditor (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-07 00:38 UTC by Erik van der Velden
Modified: 2017-08-17 17:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Erik van der Velden 2006-07-07 00:38:38 UTC 
Version:           9.0 svn (using KDE KDE 3.5.3)
Installed from:    Compiled From Sources
Compiler:          x86_64-pc-linux-gnu-3.4.6 
OS:                Linux

In >settings>IO files there are two checkboxes; one for automatic color balance and and one for camera color balance.
However, the options are actually swapped and the values are read wrongly.

The following patch fixes this:

Index: digikam/utilities/setup/setupiofiles.cpp
===================================================================
--- digikam/utilities/setup/setupiofiles.cpp    (revision 558963)
+++ digikam/utilities/setup/setupiofiles.cpp    (working copy)
@@ -333,8 +333,8 @@
     d->NRSigmaRange->setValue( config->readDoubleNumEntry("NRSigmaRange", 4.0) );
     d->SuperCCDsecondarySensor->setChecked(config->readBoolEntry("SuperCCDsecondarySensor", false));
     d->unclipColors->setChecked(config->readBoolEntry("UnclipColors", false));
-    d->cameraColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
-    d->automaticColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->cameraColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->automaticColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
     d->RGBInterpolate4Colors->setChecked(config->readBoolEntry("RGBInterpolate4Colors", false));

     d->JPEGcompression->setValue( config->readNumEntry("JPEGCompression", 75) );
Comment 1 caulier.gilles 2006-07-07 09:29:39 UTC 
SVN commit 559363 by cgilles:

Fix swaped dcraw color balance settings
BUG: 130381


 M  +2 -2      setupiofiles.cpp  


--- trunk/extragear/graphics/digikam/utilities/setup/setupiofiles.cpp #559362:559363
@@ -333,8 +333,8 @@
     d->NRSigmaRange->setValue( config->readDoubleNumEntry("NRSigmaRange", 4.0) );
     d->SuperCCDsecondarySensor->setChecked(config->readBoolEntry("SuperCCDsecondarySensor", false));
     d->unclipColors->setChecked(config->readBoolEntry("UnclipColors", false));
-    d->cameraColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
-    d->automaticColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->cameraColorBalance->setChecked(config->readBoolEntry("CameraColorBalance", true));
+    d->automaticColorBalance->setChecked(config->readBoolEntry("AutomaticColorBalance", true));
     d->RGBInterpolate4Colors->setChecked(config->readBoolEntry("RGBInterpolate4Colors", false));
 
     d->JPEGcompression->setValue( config->readNumEntry("JPEGCompression", 75) );