Bug 130376 - konqueror cannot find graphic tag
Summary: konqueror cannot find graphic tag
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml ecma (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-06 21:18 UTC by S. Umar
Modified: 2008-03-10 18:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. Umar 2006-07-06 21:18:46 UTC
Version:            (using KDE KDE 3.5.3)
Installed from:    Fedora RPMs
Compiler:          gcc-4.1.1 
OS:                Linux

Trying to open:

                 http://www.bcbst.com/

with konqueror gives an error message 

            "Error: original graphic tag not found"

coming from the source of the page itself. Viewing in Firefox 1.5.0.4
works fine.
Comment 1 Maksim Orlovich 2006-07-06 21:25:17 UTC
Actually, we find it 2 times (but fail to find it 3rd way), while mozilla only finds it once :-)

function swapImage(strOrigImage, objNewImage) {
	var objOrigImage;
	if (document.getElementById(strOrigImage) != null) objOrigImage = document.getElementById(strOrigImage);
	if (document.all != null) objOrigImage = document.all[strOrigImage];
	if (document.layers != null) objOrigImage = document.layers[strOrigImage];

	if (objOrigImage != null && objNewImage != null)
		objOrigImage.src = objNewImage.src;
	else {
		if(objOrigImage == null) alert("Error: original graphic tag not found.");
		if(objNewImage == null) alert("Error: new image object not found.");
	}
}

Carewolf: your document.layers toy breaks stuff, so it should either work better (whatever that means), or hide better..
Comment 2 Allan Sandfeld 2006-07-07 00:02:51 UTC
Actually both all and layers should equal null.. We had a patch for this years ago, and the same is done in WebCore. I'll go look for it.

The layers work as the should, the image is not a layer in this case, but might have been if you identified as NS4.
Comment 3 S. Umar 2006-07-14 02:05:45 UTC
Identification as NS4 did not do it!
Comment 4 S. Umar 2006-08-03 17:27:29 UTC
This bug is still present in 3.5.4. I would really appreciate a patch!

Thanks
Comment 5 Maksim Orlovich 2008-03-10 18:10:14 UTC
SVN commit 784105 by orlovich:

Use the new KJS hook to better hide hidden collections
BUG: 130376


 M  +4 -0      kjs_html.cpp  
 M  +1 -0      kjs_html.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=784105
Comment 6 Maksim Orlovich 2008-03-10 18:18:25 UTC
SVN commit 784110 by orlovich:

Regression test for collection hiding/130376

CCBUG:130376


 A             baseline/dom/collection-hiding.html-dom  
 AM            baseline/dom/collection-hiding.html-dump.png  
 A             baseline/dom/collection-hiding.html-render  
 A             tests/dom/collection-hiding.html  


WebSVN link: http://websvn.kde.org/?view=rev&revision=784110