Bug 130281 - Ellipse border width can't be set to 0
Summary: Ellipse border width can't be set to 0
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: unspecified Solaris
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-05 09:57 UTC by Nicolas Brisset
Modified: 2006-07-05 11:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Brisset 2006-07-05 09:57:25 UTC 
Version:           1.3.0_devel (using KDE 3.4.0, compiled sources)
Compiler:          gcc version 3.4.3
OS:                SunOS (sun4u) release 5.8

In the ellipse dialog, the width spinbow has a minimum value of 1, which makes it impossible to hide the border.
I suppose it is meant to be "0"...
Comment 1 George Staikos 2006-07-05 11:46:56 UTC 
SVN commit 558375 by staikos:

Add support for ellipses without borders

FEATURE: 130281


 M  +3 -3      kstviewellipse.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstviewellipse.cpp #558374:558375
@@ -93,7 +93,7 @@
   }
 
   const int bw(_borderWidth * p.lineWidthAdjustmentFactor());
-  QPen pen(_borderColor, bw);
+  QPen pen(bw > 0 ? _borderColor : _foregroundColor, bw);
   p.setPen(pen);
   if (_transparentFill) {
     p.setBrush(Qt::NoBrush);  
@@ -128,7 +128,7 @@
 
 void KstViewEllipse::setBorderWidth(int width) {
   if (_borderWidth != width) {
-    _borderWidth = kMax(1, width);
+    _borderWidth = kMax(0, width);
     setDirty();
   }
 }
@@ -160,7 +160,7 @@
   } else if (propertyName == "borderWidth") {
     map.insert(QString("_kst_widgetType"), QString("QSpinBox"));
     map.insert(QString("_kst_label"), i18n("Border width"));    
-    map.insert(QString("minValue"), 1);
+    map.insert(QString("minValue"), 0);
   } else if (propertyName == "fillColor") {
     map.insert(QString("_kst_widgetType"), QString("KColorButton"));
     map.insert(QString("_kst_label"), i18n("Fill Color"));