Bug 130230 - wrong date in header using date-view
Summary: wrong date in header using date-view
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Dates (show other bugs)
Version: 0.8.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-04 01:59 UTC by Erwin Bauer
Modified: 2019-12-27 22:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments
described problem (144.76 KB, image/png)
2008-12-23 11:05 UTC, Andi Clemens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erwin Bauer 2006-07-04 01:59:15 UTC
Version:           0.8.2-rc1-0ubuntu3 (using KDE KDE 3.5.2)
Installed from:    Ubuntu Packages
OS:                Linux

to reproduce: have some pictures from different months (e.g. May, June, July). put them in one album with one date, e.g. July. change from album view to date view using the tabs on the left. in the date list on the left the correspondig months are listed correctly, in the main view the pictures sorted according to the date, but the headers show the date of the album, which may not map to the date of the pictures. this ist not an intuitive behaviour!
Comment 1 caulier.gilles 2008-12-04 21:00:30 UTC
Erwin, 

What's news about this report. It still valid using digiKam 0.9.4 or 0.10.0 ?

Gilles Caulier
Comment 2 caulier.gilles 2008-12-05 18:44:48 UTC
No response...

Andi, Marcel, Arnd, Mik,

it still valid with 0.10.0 ? If no, we can close it...

Gilles Caulier
Comment 3 Andi Clemens 2008-12-05 20:32:44 UTC
SVN commit 893026 by aclemens:

fix album headers: it displayed "MONTH 2,008" instead of "MONTH 2008"

CCBUG:130230

 M  +1 -1      albumicongroupitem.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=893026
Comment 4 Thomas McGuire 2008-12-06 14:33:17 UTC
> What's news about this report. It still valid using digiKam 0.9.4 or 0.10.0 ?

It is still valid with 0.10.0 beta7.
Comment 5 Mikolaj Machowski 2008-12-06 20:35:34 UTC
Finally! I can close something as fixed ;)
Comment 6 Andi Clemens 2008-12-06 21:10:50 UTC
? It is not fixed yet...
Comment 7 Andi Clemens 2008-12-06 21:15:26 UTC
I guess this bugreport is the same as this one:
http://bugs.kde.org/show_bug.cgi?id=156599

Andi
Comment 8 Andi Clemens 2008-12-23 11:05:05 UTC
Created attachment 29572 [details]
described problem

I don't really know what to do with this bugreport. For me it is not a bug, because the date you see in the album header is the date of the album, not the one of the current view.
One simple solution for me would be to just don't display the album date at all in this view.

Gilles, Marcel, Arnd,

what do you think about this report?

Andi
Comment 9 caulier.gilles 2008-12-23 11:11:03 UTC
Andi,

My proposal: change text in album header like this :

"My Album
 Created at December 2008 - 1 item"

The "Created at" prefix is explicit : it's creation date of album, not a synthesis of dates taken from album contents. It's simple and fast...

Gilles Caulier

Comment 10 Andi Clemens 2008-12-23 11:15:41 UTC
Yes, sound good. I'll check that...

Andi
Comment 11 Andi Clemens 2008-12-23 11:24:32 UTC
SVN commit 900563 by aclemens:

be more verbose in album header label: use "Created on" prefix to reduce
confusion when displaying images in date view.

CCBUG:130230

 M  +1 -1      albumicongroupitem.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=900563
Comment 12 Andi Clemens 2008-12-23 11:25:47 UTC
Ok, done. I will not close this one because we might need other opinions here?
For me it is ok...

+1 for the prefix :-)

Andi
Comment 13 Thomas McGuire 2008-12-23 12:01:00 UTC
In the long run, I think the best way to fix this is to implement bug 134389 (ability to hide album headers and sort the images without taking album borders into account). This way, for the date view, we could by default hide album headers, and this problem wouldn't be there.
Comment 14 caulier.gilles 2008-12-23 12:16:14 UTC
>In the long run, I think the best way to fix this is to implement bug 134389 

I'm agree.

> This way, for the date view, we could by default hide album headers, and this 
> problem wouldn't be there. 

I'm not agree. Hiding album header will introduce new bug report.

Gilles Caulier
Comment 15 Arnd Baecker 2008-12-23 12:29:55 UTC
Ad #c13: but then the problem is only hidden (and I really would like
to have the merged view, but as something which can be changed by the user,
because the separation by folders is also useful in several other situations).

I am not sure, whether the "Created on" is the right solution:
the album date can be:
- an average of all images
- the date of the first image
- a date, specified by the user
So I think that: "Album date: ...." would better describe its meaning
as it not necessarily reflects the creation date (which is pretty
irrelevant for an album IMO).

(Actually, I would prefer, that the Album date also includes the day and not just month/year)
Comment 16 Andi Clemens 2008-12-23 12:55:50 UTC
Maybe we should use the shortform of the month then, because it gets really long:

/My Albums/Test01
Album Date: 12 Dec 2008, 100 items
Comment 17 Mikolaj Machowski 2008-12-23 13:04:39 UTC
For me adding more descriptive header is enough. Also +1 for shortening of month. Not because of length but due to nature of some languages. For example in Polish when using whole name you should change case depending on context, eg. proper translation should be:

Album date: 12 December 2008 -> Data albumu: 12 grudnia 2008
------------------------------------------------^^^^^^^

Gettext mechanism doesn't allow for that and it will insert only "12 grudzien 2008" which is awkward (although not ungrammatical).

With shortening of month name we (in Poland) will get: "12 Gru 2008" which is completely neutral.
Comment 18 Andi Clemens 2008-12-23 13:10:42 UTC
Ok patch would be ready... waiting for more comments here...

Andi
Comment 19 Andi Clemens 2008-12-30 10:15:44 UTC
I will commit this patch now, if someone doesn't like it, we can change it again :-)
Comment 20 Andi Clemens 2008-12-30 10:17:41 UTC
SVN commit 903229 by aclemens:

using "Album Date:" with the shortened month name in album header as suggested in bug 130230

CCBUG:130230

 M  +7 -4      albumicongroupitem.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903229
Comment 21 caulier.gilles 2009-01-01 14:25:16 UTC
Andi,

This file is fixed now ?

Gilles Caulier
Comment 22 Andi Clemens 2009-01-01 14:36:33 UTC
If everybody is happy with the current solution, it could be closed.
But I didn't got response so far.

Andi
Comment 23 caulier.gilles 2009-01-01 14:37:26 UTC
For me it's fine

Gilles
Comment 24 Andi Clemens 2009-01-03 11:32:18 UTC
What about the original post? I think it is invalid.
If nobody is commenting on this anymore, I will close the file today...

Andi
Comment 25 caulier.gilles 2009-01-03 11:45:11 UTC
Agree for me

Gilles
Comment 26 Andi Clemens 2009-01-03 14:39:44 UTC
I will close it now, if more discussion is needed, feel free to re-open it again.

Andi
Comment 27 caulier.gilles 2019-12-27 22:57:14 UTC
Not reproducible with 7.0.0-beta1