Bug 130060 - When editing messages, HTML composing option persists even for plain text messages
Summary: When editing messages, HTML composing option persists even for plain text mes...
Status: RESOLVED INTENTIONAL
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-30 11:07 UTC by Jonathan Marten
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Marten 2006-06-30 11:07:01 UTC
Version:            (using KDE KDE 3.5.3)
Installed from:    Compiled From Sources
Compiler:          gcc version 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9)
 
OS:                Linux

Compose a message, switch to HTML mode and apply some formatting.  Save the message to the drafts folder.  Compose another message, this time in plain text without HTML, and also save it to the drafts folder.  (Presumably the same will also happen in the other folder which allows message editing - the outbox).

Open the HTML message for editing; it will be shown with the formatting toolbar as expected.  Now close that and open the plain text message; it will also be shown with the formatting toolbar and HTML mode enabled.  Turn off HTML and re-save the plain text draft, then open it again; it will this time be in plain text mode as expected.

Composing new messages is a separate option; it is reasonable for the HTML option to be persistent here.  But, when editing existing messages, I would expect the HTML option to track the message format: in other words, enable HTML formatting of a HTML draft is being edited, or turn it off for a plain text draft.

This could be fixed by doing:

     toggleMarkup(false);

at the beginning of KMComposeWin::setMsg() - if the message really is HTML then the option will get turned on again later.
Comment 1 Ingo Klöcker 2006-06-30 15:55:06 UTC
That would make the code overly complicated because we'd have to keep track whether an old message or a new message is editted in order to now whether the status of the HTML composing option should be saved or not.

In any case, KMail only creates HTML messages if HTML formatting is used. If you don't use any then KMail will send the message as plain text message regardless of the setting of Options->Formatting.