Bug 129983 - automatic spell check setting lost when switching conversation tabs
Summary: automatic spell check setting lost when switching conversation tabs
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Chat Window (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 19:39 UTC by Vladimir Kanazir
Modified: 2008-07-13 19:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix spellchecking (7.74 KB, patch)
2008-07-12 21:48 UTC, Roman Jarosz
Details
Fix spellchecking, follow context menu changes (9.02 KB, patch)
2008-07-13 00:33 UTC, Dennis Nienhüser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kanazir 2006-06-28 19:39:53 UTC
Version:            (using KDE KDE 3.5.3)
Installed from:    Fedora RPMs

Automatic spelling is disabled globally.
When I enable it in some tab, it works until I switch to another tab. When I get back, spell checker is disabled.
Comment 1 P B 2006-07-11 19:41:39 UTC
Can confirm for 0.12.0 on 3.5.3, using Slackware packages, and aspell selected in Control Centre.

Auto Spell Check works fine once turned on (via chat window text entry context menu), but yes, switching to another conversation tab and flicking back (even if that is all you do) loses the setting.

This is despite having it switched on in the preferences. This default is seemingly ignored.
Comment 2 Shawn Sharpe 2006-07-21 05:23:10 UTC
I'm having the same problem with .12 in kubuntu Dapper.
Comment 3 fran6co 2006-10-13 00:36:11 UTC
Me too with kopete 0.12.3 in kubuntu edgy. (kde 3.5.5)
Comment 4 Abe Ezekowitz 2007-02-27 19:40:01 UTC
This also happens to me under Kubuntu Edgy using Kopete version 0.12.4. I'm using KDE version 3.5.6
Comment 5 Manuel Quinteiro 2007-10-18 16:55:49 UTC
*** This bug has been confirmed by popular vote. ***
Comment 6 Florian Reinhard 2008-07-12 01:53:37 UTC
can confirm for svn trunk r830858 (~4.1-beta2)
Comment 7 Roman Jarosz 2008-07-12 21:48:57 UTC
Created attachment 26066 [details]
Fix spellchecking

Fixes bug when spellchecker is always disabled by remembering if it was enabled
or disabled. The patch also removes restriction that spellchecker can't be
enabled if richtext is enabled. This restriction isn't needed anymore because
KTextEdit uses Highlighter.

It would be great if somebody could also test it and/or review it as I want to
push it into KDE 4.1.
Comment 8 Dennis Nienhüser 2008-07-13 00:33:41 UTC
Created attachment 26070 [details]
Fix spellchecking, follow context menu changes

Update of the patch that doesn't return something in the void toggle...
function and introduces an additional slot for updating the spell check action:
It is needed to listen to changes of the auto spell setting made through the
context menu action of the KTextEdit. This way the auto spell check setting in
the menu is also updated when the setting is changed through the context menu.
Comment 9 Dennis Nienhüser 2008-07-13 00:34:41 UTC
Oh, and working fine btw, so +1 for commiting from me :-)
Comment 10 Matt Rogers 2008-07-13 01:26:35 UTC
Looks fine to me. Please commit
Comment 11 Roman Jarosz 2008-07-13 19:14:56 UTC
SVN commit 831935 by rjarosz:

Allow spell-checking on html/rtf text.
Save spellchecker settings for every chat window.
Use global spellchecker settings (enable/disable).

Patch checked and updated by Dennis Nienhüser.

BUG: 136193
BUG: 129983
BUG: 160909



 M  +0 -27     chattexteditpart.cpp  
 M  +0 -15     chattexteditpart.h  
 M  +2 -2      chatview.cpp  
 M  +12 -35    kopetechatwindow.cpp  
 M  +3 -2      kopetechatwindow.h  
 M  +10 -6     krichtexteditpart.cpp  
 M  +12 -0     krichtexteditpart.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=831935
Comment 12 Roman Jarosz 2008-07-13 19:15:34 UTC
SVN commit 831936 by rjarosz:

Backport commit 831935.
Allow spell-checking on html/rtf text.
Save spellchecker settings for every chat window.
Use global spellchecker settings (enable/disable).

Patch checked and updated by Dennis Nienhüser.

CCBUG: 136193
CCBUG: 129983
CCBUG: 160909



 M  +0 -27     chattexteditpart.cpp  
 M  +0 -15     chattexteditpart.h  
 M  +2 -2      chatview.cpp  
 M  +12 -35    kopetechatwindow.cpp  
 M  +3 -2      kopetechatwindow.h  
 M  +10 -6     krichtexteditpart.cpp  
 M  +12 -0     krichtexteditpart.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=831936