Bug 129789 - Missing feature like Layer / Color / Levels in GIMP
Summary: Missing feature like Layer / Color / Levels in GIMP
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-25 14:44 UTC by Stéphane
Modified: 2006-10-21 15:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Levels filter proposal (89.55 KB, image/png)
2006-10-18 22:03 UTC, Frédéric COIFFIER
Details
Levels filter proposal (2) (123.30 KB, image/png)
2006-10-20 18:33 UTC, Frédéric COIFFIER
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane 2006-06-25 14:44:12 UTC
Version:           1.5.0 (using KDE KDE 3.5.2)
Installed from:    Ubuntu Packages
OS:                Linux

For me it's the most useful feature I use to correct a photo.
Screenshot of GIMP : http://docs.gimp.org/images/toolbox/tools-levels.png

Thanks in advance.
Comment 1 Frédéric COIFFIER 2006-10-11 20:11:06 UTC
I agree : this feature is really important for scanned picture and photos to adjust the contrast.

This plugin is absolutely not difficult to implement.
Comment 2 Halla Rempt 2006-10-11 20:20:08 UTC
Frédéric, is this something you could help us with? It's not the difficulty,
and we've had some internal discussions on, for instance, taking LightZone (which is slightly more sophisticated) as an example. But the problem is simply that we're already overloaded with work on Krita 2.0. A plugin for 1.6 would be easy, could easily be redistributed and it wouldn't be too hard for us to port to 2.0. There's a plugin writers howto at http://www.koffice.org/krita/Developing Krita Plugins.html -- and if you'd like to give it a try, you can find us almost always at irc.freenode.org, #koffice.
Comment 3 Frédéric COIFFIER 2006-10-18 22:03:10 UTC
Created attachment 18179 [details]
Levels filter proposal
Comment 4 Frédéric COIFFIER 2006-10-18 22:17:10 UTC
I began a new level filter (see the attached screenshot).

But, I have several problems :
1. I need a float QSpinBox
2. I need a custom slider (like in Gimp)
3. I don't know if my method is the best for a 16-bit picture. In fact, I use the createBrightnessContrastAdjustment() function and this one needs a 256 value array (from black to white). But, I think, for a 16-bit picture, there are 65536 levels between black and white.

Have you some suggestions ?
About 2, I think I can do myself a new widget.
Comment 5 Stéphane 2006-10-18 22:25:37 UTC
It miss the 5 cursors on the 2 bars, except that it's exactly what we need ;-)
Comment 6 Halla Rempt 2006-10-18 22:30:41 UTC
Sounds good and interesting. Could you come on irc to discuss the issues you
mention? irc.freenode.org, #koffice. That may be the fastest way to get your 
answers.

About your points:

1: Qt4 has a double spinbox; if you're working against 1.6 (which would be wise atm), then we'll have to find an equivalent. They do exist, though.
http://www.billbaxter.com/code/floatspin/ is an example.

2: that's indeed something you will probably have to write yourself, although you may be able to re-use code from gradient sliders (those have a couple of value points that you can move with a mouse, too)

3: We've got something for that in the histogram combobox: basically, it's
a zoom option that either shows a compressed histogram or a section of the histogram. You may be able to reuse that.

2
Comment 7 Halla Rempt 2006-10-18 22:49:51 UTC
Sounds good and interesting. Could you come on irc to discuss the issues you
mention? irc.freenode.org, #koffice. That may be the fastest way to get your 
answers.
Comment 9 Frédéric COIFFIER 2006-10-20 18:33:58 UTC
Created attachment 18206 [details]
Levels filter proposal (2)
Comment 10 Frédéric COIFFIER 2006-10-20 18:37:12 UTC
You can see my current version in attachment.
Missing things :
- A channel selector
- A entry for the gamma value (I think it will be easier to do than a float SpinBox and the SpinBox isn't really useful in this case as we already have the slider)

Can anyone audit my source code ?
Comment 11 Cyrille Berger 2006-10-20 18:48:11 UTC
can you send it to kimageshop@kde.org ?
Comment 12 Halla Rempt 2006-10-20 19:01:06 UTC
That's cool! The channel selector you can rip from the current color 
adjustment dialog. If you've got source code, please send them to the mailing 
list. We'll probably jump with joy and give some comments :-)
Comment 13 Halla Rempt 2006-10-21 15:33:28 UTC
It's gone into subversion. Thanks Frédéric!