Bug 128531 - hide or show menubar titles in kmix mixed up
Summary: hide or show menubar titles in kmix mixed up
Status: RESOLVED FIXED
Alias: None
Product: kmix
Classification: Applications
Component: general (show other bugs)
Version: 2.6
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Christian Esken
URL:
Keywords:
: 147127 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-03 01:18 UTC by Ambroz Bizjak
Modified: 2007-12-30 01:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ambroz Bizjak 2006-06-03 01:18:42 UTC
Version:           2.6 (using KDE 3.5.2, Gentoo)
Compiler:          gcc version 3.4.4 (Gentoo 3.4.4-r1, ssp-3.4.4-1.0, pie-8.7.8)
OS:                Linux (i686) release 2.6.16

There are two ways to hide or show the menubar in kmix. One is to use the Settings menu and click Hide or Show menubar, and another to right-click int the mixer and do the same. However, these menu items dont't display correct text (either "Show Menubar" or "Hide Menubar"). If I click "Hide Menubar" in the Settings menu, the menubar is hidden, but right-clicking on the mixer shows a menu item still called "Hide Menubar", although the menubar is already hidden.
Comment 1 Christian Esken 2006-11-24 20:27:01 UTC
Confirmed. I'll look into this.
Comment 2 Christian Esken 2006-11-24 21:19:19 UTC
I investigated this. It sounds trivial, but it will take an insane amount of work to fix this. If somebody else wants to take over, I'll be happy to assist.
Otherwise I'll leave this rather cosmetic issue open until KDE4.
So for now the taarget milestone is KDE4.

--------
Internal remark: What would have to be done:
1) In KMixWindow::toggleMenuBar() iterate over all m_mixerWidgets items sending signals to all KMixerWidget instances (or if possible connect a signal from a menubar slot during construction phase).
2) In the KMixerWidget, implement a Solt to forward the signal to all Views.
3) In the Views, implement the menu change.
4) Make sure the special Views (DockIcon, PanelAppplet) are not harmed
Comment 3 Christian Esken 2007-06-24 22:16:28 UTC
*** Bug 147127 has been marked as a duplicate of this bug. ***
Comment 4 Christian Esken 2007-12-30 01:04:08 UTC
Fixed in KDE4.
Actually it is a bit different there: The text is always "Show Menubar", but there is a check mark as indicator. This check mark is correct now.