Bug 128432 - Nicklist window needlessly shows horizontal scrollbar
Summary: Nicklist window needlessly shows horizontal scrollbar
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-01 11:00 UTC by Wolf Giesen
Modified: 2006-09-04 12:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Nicklist scrollbar without touching anything (27.11 KB, image/jpeg)
2006-06-01 11:01 UTC, Wolf Giesen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wolf Giesen 2006-06-01 11:00:13 UTC
Version:           SVN (using KDE KDE 3.5.2)
Installed from:    Gentoo Packages
Compiler:          gcc-3.4.6 (x86) -O2 -march=pentium4
OS:                Linux

Konvi shows a horiz scrollbar in the nicklist without need.

To reproduce the screenie, I did:

1. start konvi
2. connect & join new channel

Once I drag the vertical separator between channel and nicklist for about one pixel to the right or left, the scrollbar vanishes.
Comment 1 Wolf Giesen 2006-06-01 11:01:22 UTC
Created attachment 16395 [details]
Nicklist scrollbar without touching anything
Comment 2 Eike Hein 2006-08-29 19:09:52 UTC
SVN commit 578579 by hein:

Don't show unnecessary horizontal scrollbars.
BUG:128432


 M  +4 -3      channel.cpp  
 M  +1 -1      commit.h  
 M  +1 -0      viewtree.cpp  


--- trunk/extragear/network/konversation/src/channel.cpp #578578:578579
@@ -192,6 +192,7 @@
     nickListButtons->setSpacing(spacing());
 
     nicknameListView=new NickListView(nickListButtons, this);
+    nicknameListView->setHScrollBarMode(QScrollView::AlwaysOff);
     nicknameListView->setSelectionModeExt(KListView::Extended);
     nicknameListView->setAllColumnsShowFocus(true);
     nicknameListView->setSorting(1,true);
@@ -2245,8 +2246,7 @@
     if(state)
     {
         // we can't have automatic resizing with three columns; the hostname column is too wide
-        nicknameListView->setResizeMode(QListView::NoColumn);
-        nicknameListView->setColumnWidthMode(1,KListView::Maximum);
+        nicknameListView->setHScrollBarMode(QScrollView::Auto);
 
         // restart userhost timer
         userhostTimer.start(10000);
@@ -2256,6 +2256,7 @@
             // re-add the hostmask column
             nicknameListView->addColumn(QString::null);
             nicknameListView->setColumnWidthMode(2,KListView::Maximum);
+            nicknameListView->setResizeMode(QListView::NoColumn);
 
             // re-add already known hostmasks
             QListViewItem* item=nicknameListView->itemAtIndex(0);
@@ -2271,7 +2272,7 @@
     {
         userhostTimer.stop();
         if(nicknameListView->columns()==3) nicknameListView->removeColumn(2);
-
+        nicknameListView->setHScrollBarMode(QScrollView::AlwaysOff);
         // make the nick column resize itself automatically to prevent horizontal scrollbar
         nicknameListView->setResizeMode(QListView::LastColumn);
     }
--- trunk/extragear/network/konversation/src/commit.h #578578:578579
@@ -1,4 +1,4 @@
 // This COMMIT number is added to version string to be used as "patch level"
 #ifndef COMMIT
-#define COMMIT 3152
+#define COMMIT 3153
 #endif
--- trunk/extragear/network/konversation/src/viewtree.cpp #578578:578579
@@ -34,6 +34,7 @@
     : KListView(parent)
 {
     header()->hide();
+    setHScrollBarMode(QScrollView::AlwaysOff);
 
     addColumn(i18n("Tabs"));
     setSortColumn(0);
Comment 3 Wolf Giesen 2006-09-04 12:53:13 UTC
Thanks!