Bug 128352 - Option to make all lines orthogonal
Summary: Option to make all lines orthogonal
Status: REOPENED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Andi Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-31 09:33 UTC by Rutger Claes
Modified: 2023-01-14 07:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rutger Claes 2006-05-31 09:33:27 UTC
Version:           1.5.3 (using KDE 3.5.2, Debian Package 4:3.5.2-2+b1 (testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.16-13

It would be nice if each diagram had an option that only allows orthogonal connections.
All non orthogonal lines could be made orthogonal when the option is activated.  When a new line is drawn, it is also orthogonal (much like dia does when connecting boxes with a "zigzag" line).
Comment 1 Oliver Kellogg 2007-02-08 07:03:58 UTC
How is this different from the "use angular association lines" checkbox
in the Settings->Configure->General Settings?
Comment 2 Mohamed Bouarfa 2007-12-04 11:52:52 UTC
Use angular association line is different from orthogonal...
I vote for this wish
Comment 3 Ralf Habacker 2013-11-14 21:49:32 UTC

*** This bug has been marked as a duplicate of bug 107174 ***
Comment 4 Ralf Habacker 2013-11-14 21:55:44 UTC
Reopened because bug 107174 do not cover converting all associations of a diagram to orthogonal lines
Comment 5 Oliver Kellogg 2023-01-13 22:21:18 UTC
(In reply to Oliver Kellogg from comment #1)
> How is this different from the "use angular association lines" checkbox
> in the Settings->Configure->General Settings?

Meanwhile, the option "Use angular association lines" is not hooked up at all in the code, i.e. it only exists as a GUI element.
TODO: Remove the dead checkbox.
Comment 6 Oliver Kellogg 2023-01-14 07:14:05 UTC
Git commit c91b46e6a95c29305196b3e709b72de5cf34c2b8 by Oliver Kellogg.
Committed on 14/01/2023 at 07:13.
Pushed by okellogg into branch 'master'.

Address https://bugs.kde.org/show_bug.cgi?id=128352#c5 :

umbrello/dialogs/pages/uioptionspage.{h,cpp}
- Remove QCheckBox *m_angularLinesCB.

umbrello/optionstate.cpp
- Remove bool angularlines.

umbrello/umbrello.kcfg
- In group "General Options" remove Bool angularlines.

M  +0    -6    umbrello/dialogs/pages/uioptionspage.cpp
M  +0    -1    umbrello/dialogs/pages/uioptionspage.h
M  +0    -2    umbrello/optionstate.cpp
M  +0    -2    umbrello/optionstate.h
M  +0    -5    umbrello/umbrello.kcfg

https://invent.kde.org/sdk/umbrello/commit/c91b46e6a95c29305196b3e709b72de5cf34c2b8