Bug 128211 - (Flickr Export) "Ok" Button in "Add Photos" shouldn't fire upload directly
Summary: (Flickr Export) "Ok" Button in "Add Photos" shouldn't fire upload directly
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Flickr (show other bugs)
Version: 5.6.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-28 22:11 UTC by Helder Ribeiro
Modified: 2018-03-23 12:08 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.1.0


Attachments
new FlickrExport dialog (478.75 KB, image/png)
2008-05-22 12:48 UTC, caulier.gilles
Details
new FlickrExport dialog (2) (45.03 KB, image/png)
2008-05-22 12:48 UTC, caulier.gilles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helder Ribeiro 2006-05-28 22:11:27 UTC
Version:           0.8.1 (using KDE 3.4.3, Gentoo)
Compiler:          gcc version 3.3.6 (Gentoo 3.3.6, ssp-3.3.6-1.0, pie-8.7.8)
OS:                Linux (i686) release 2.6.16-gentoo-r7

I'm using Kipi plugins 0.1.2 and the behavior of the Flickr Export "Add Photos" dialog is rather strange.

What one would expect (me, at least) is that you selected the photos you want to export, click "Ok", go back to the original window (the one with the tags and resize options), where it shows you a list of the ones you selected with a little preview panel on the right (possibly in that big blank area under the "overwrite default options" panel), and THEN you can confirm, clicking some "Export" or "Upload" button.

The present behavior surprised me the first time I used Flickr Export, because I thought of first selecting the pictures I wanted to export and *then* choosing the other options, but when I clicked "ok" it went on uploading them already. And as it seems that if you click "Cancel" it finishes sending the first selected picture nonetheless, and as I hadn't set the "resize" option before, I lost some precious piece of my 20Mb quota.

Thanks for any help!
Comment 1 Vardhman 2006-05-29 12:47:42 UTC
I understand the problem, Earlier we had discussion on ways to improve the image selection dialog to have some good preview functionality (currently only single image preview work, multiple selection preview doesn't)

In that scenerio would it still be required to have this kind of preview functionality before firing uploads?

BTW, would also like to understand if the changing the "Add photo" string to some thing like "Select and Upload photo" would do the job ? 

[Its my attempt to avoid duplicating the image selection code in to this plugin code.]
Just looking for some view points.

Vardhman
Comment 2 Helder Ribeiro 2006-05-29 14:39:47 UTC
I think the preview functionality would help but not eliminate the problem. The thing is it is a common behavior for one to be in a dialog, have to open a different dialog to select whatever elements, then see them back in the first dialog, choose some other options and then confirm whatever the first dialog was supposed to do with those elements. That happens in a lot of applications, in many different situations. See the Email Images plugin for example.

If you leave aside the "common behavior" perspective, in this particular case of Flickr Export the problem is that the linearity of its behavior is not reflected by the interface. The plugin clearly requires you to do one thing (set options, tags, etc.) and *then* the other (select and upload photos).

You can change its behavior (perhaps to the "common"/non-linear behavior mentioned above), *or* you can change the interface to reflect the behavior it already has, perhaps by having a wizard-like scheme where one would only set tags, privacy and resize options, then click *NEXT* and then be presented with the select window (which wouldn't be a popup, since its "Ok" button would, in this case, be a "Finish" button).

I hope I have managed to explain myself. Thanks for your attention.

P.S.: What's this "Add CC" thing in Bugzilla?
Comment 3 Vardhman 2006-07-15 18:52:03 UTC
Helder,
      Can you check the latest subversion code for the plugin ? I remember having put a select image for upload button, which only creates the list of files to upload, it drops you to main window again and you can set options for the image before clicking the start uploading button.

I understand that you would like to have a preview of all the images and select/deselect some of them, but is your problem otherwise solved ?

I will checkout how I can provide option to change the earlier selection or make a better file select dialog.

regards
Vardhman
Comment 4 caulier.gilles 2008-05-22 12:44:49 UTC
Hi all,

The current implementation of the plugins is very improved now. the dialog as a list of items to upload. The items are removed automatically when uploading is a success. You can add/or remove item.

Note : item previewis wierd, because we use KDE preview KIOSLave, witch is an uncomplete and dumy tool. I have no others ways for KDE3. You will see no preview for any JPEG compression level images, broken PNG, broken TIFF, no RAW.

With KDE4 port, no _all_ plugins use preview interface designed to kipi host. this is want mean than with digiKam, all file format are supported _properlly_. Also preview is cached in memory. it's very fast and very powerfull.

I have also redesigned the image selection dialog to be more instructive (use digiKam preview tools) and display main photo metadata info !

For me, this file is now fixed. I close it

Gilles Caulier
Comment 5 caulier.gilles 2008-05-22 12:48:23 UTC
Created attachment 24888 [details]
new FlickrExport dialog
Comment 6 caulier.gilles 2008-05-22 12:48:47 UTC
Created attachment 24889 [details]
new FlickrExport dialog (2)