Version: 0.8.1 (using KDE 3.4.3, Gentoo) Compiler: gcc version 3.3.6 (Gentoo 3.3.6, ssp-3.3.6-1.0, pie-8.7.8) OS: Linux (i686) release 2.6.16-gentoo-r7 I'm using kipi plugins 0.1.2 and the Flickr Export plugin takes full control of the application while in the "Uploading" progress window (it does also when it's not actually uploading). This isn't good because the upload can take very long and one can't do anything else on Digikam until it's done. It'd be nice if the "Uploading" window could be sent to the background while one keeps working in the rest. Thanks a lot!
Hi, I was kind of aware of the modalness issue with the kipi-plugin, I thought it wasn't that bad. Now that its reported as bug, I should bother about it ;) I just checked the possible code that code be making the window Modal, I figured out the constructor of FlickrWindow calls KDialogBase constructor with a modal paramater set true, I set it false and even now the window remains Modal. FlickrWindow::FlickrWindow(KIPI::Interface* interface,const QString &tmpFolder, QWidget *parent) : KDialogBase(parent, 0, false, i18n( "FlickrUploadr" ), Help|Close, Close, false),m_tmp(tmpFolder) 3rd agrument above is for modality earlier it was true, now even when Its set false, the plugin window takes the control of the application. i.edoesn't allow the user to use the host application, which might be disliked by user. Is there any reason for this, in the sense its necessary required to be so or can someone suggest how to remove this bug ? Vardhman On 27 May 2006 23:40:53 -0000, Gilles Caulier <caulier.gilles@free.fr> wrote: [bugs.kde.org quoted mail] Hi,<br> I was kind of aware of the modalness issue with the kipi-plugin, I thought it wasn't that bad. Now that its reported as bug, I should bother about it ;)<br><br>I just checked the possible code that code be making the window Modal, I figured out the constructor of FlickrWindow calls KDialogBase constructor with a modal paramater set true, I set it false and even now the window remains Modal. <br><blockquote>FlickrWindow::FlickrWindow(KIPI::Interface* interface,const QString &tmpFolder, QWidget *parent)<br> : KDialogBase(parent, 0, false, i18n( "FlickrUploadr" ), Help|Close, Close, false),m_tmp(tmpFolder) <br></blockquote>3rd agrument above is for modality earlier it was true, now even when Its set false, the plugin window takes the control of the application. i.e doesn't allow the user to use the host application, which might be disliked by user. <br><br>Is there any reason for this, in the sense its necessary required to be so or can someone suggest how to remove this bug ?<br><br><br>Vardhman<br><div><span class="gmail_quote">On 27 May 2006 23:40:53 -0000, <b class="gmail_sendername"> Gilles Caulier</b> <<a href="mailto:caulier.gilles@free.fr">caulier.gilles@free.fr</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> ------- You are receiving this mail because: -------<br>You are the assignee for the bug, or are watching the assignee.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=128158">http://bugs.kde.org/show_bug.cgi?id=128158 </a><br>caulier.gilles free fr changed:<br><br> What |Removed |Added<br>----------------------------------------------------------------------------<br> AssignedTo|digikam-devel kde org |kde-imaging kde org <br> Product|digikam |kipiplugins<br> Version|0.8.1 |unspecified<br>_______________________________________________<br>Kde-imaging mailing list<br><a href="mailto:Kde-imaging@kde.org"> Kde-imaging@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/kde-imaging">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br></blockquote></div><br><br clear="all"><br>-- <br>Blogs: <a href="http://vardhman.blogspot.com"> http://vardhman.blogspot.com</a><br>
If you use a null parent, a minimize button will be available. Also, look in SendImages or BatchProcess plugin, dialog are modal. Gilles
Gilles, I did try setting the parent to Null in the KdialogBase initializatoin call but the dialog still seems to be model. The send email and batch process you asked me to look at are also themselves modal. Could you please explain me again, if I got it wrong ?
Look like digiKam cameragui use this technic : http://websvn.kde.org/trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp?rev=541880&view=markup look the comments of this commit and the CameraUI constructor form ! There is an annotation for you in the code... In flicker plugin, witch dialog you want to fix like this. I have checked the code in svn, and the parent of dialog aren't null everywhere... Gilles
Also, in the flicker plugin, the KdialogBase::show() method must be used instead the KdialogBase::exec() method. Look the QDialog documentation for more detail : http://doc.trolltech.com/3.3/qdialog.html#show Gilles
Hi, When I use a KdialogBase::show() instead of KdialogBase::exec() in the plugin_flickrexport.cpp file (where the instance of the plugin is created) the plugin window doesn't stay, it just returns! What I want to achieve finally is that flickrexport plugin opens as a separate window kind off, and the user can minimise it and keep working with digikam, I don't know if this kind of functionality is expected or possibly from plugin, but it is targetted to be similar to the imageViewer window, which remains unmodal and allows user to work on digikam main window while this window is open for a picture. I haven't commited any code after setting the parent to Null (our constructors seems to be different ones' the one I used has the modal argument as 3rd and parent as 1st), since the code change didn't work as expected. Vardhman On 29 Jun 2006 06:04:18 -0000, Gilles Caulier <caulier.gilles@free.fr> wrote: [bugs.kde.org quoted mail] Hi,<br> When I use a KdialogBase::show() instead of KdialogBase::exec() in the plugin_flickrexport.cpp file (where the instance of the plugin is created) the plugin window doesn't stay, it just returns! <br><br>What I want to achieve finally is that flickrexport plugin opens as a separate window kind off, and the user can minimise it and keep working with digikam, I don't know if this kind of functionality is expected or possibly from plugin, but it is targetted to be similar to the imageViewer window, which remains unmodal and allows user to work on digikam main window while this window is open for a picture. <br><br>I haven't commited any code after setting the parent to Null (our constructors seems to be different ones' the one I used has the modal argument as 3rd and parent as 1st), since the code change didn't work as expected. <br><br>Vardhman<br><div><span class="gmail_quote">On 29 Jun 2006 06:04:18 -0000, <b class="gmail_sendername">Gilles Caulier</b> <<a href="mailto:caulier.gilles@free.fr">caulier.gilles@free.fr</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> ------- You are receiving this mail because: -------<br>You are on the CC list for the bug, or are watching someone who is.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=128158">http://bugs.kde.org/show_bug.cgi?id=128158 </a><br><br><br><br><br>------- Additional Comments From caulier.gilles free fr 2006-06-29 08:04 -------<br>Also, in the flicker plugin, the KdialogBase::show() method must be used instead the KdialogBase::exec() method. Look the QDialog documentation for more detail : <br><br><a href="http://doc.trolltech.com/3.3/qdialog.html#show">http://doc.trolltech.com/3.3/qdialog.html#show</a><br><br>Gilles<br>_______________________________________________<br>Kde-imaging mailing list<br><a href="mailto:Kde-imaging@kde.org"> Kde-imaging@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/kde-imaging">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br></blockquote></div><br><br clear="all"><br>-- <br>Blogs: <a href="http://vardhman.blogspot.com"> http://vardhman.blogspot.com</a><br>
send me patch with your implementation, i will take a look... Gilles
Done, thanks to Gilles.