Bug 127889 - untranslatable strings in kttsmgr audio tab
Summary: untranslatable strings in kttsmgr audio tab
Status: RESOLVED FIXED
Alias: None
Product: kttsd
Classification: Unmaintained
Component: kttsmgr (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-23 17:39 UTC by Burkhard Lück
Modified: 2011-05-25 04:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (45.63 KB, image/png)
2006-05-24 21:30 UTC, Thomas Reitelbach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2006-05-23 17:39:10 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

in the audio tab of kttsmgr there are untranslatable strings in the listbox alsa device.

just a guess: missing i18n() calls here? 

kdestable@rebutia:~/svn$ svn diff kdeaccessibility/kttsd/
Index: kdeaccessibility/kttsd/players/alsaplayer/alsaplayer.cpp
===================================================================
--- kdeaccessibility/kttsd/players/alsaplayer/alsaplayer.cpp    (revision 542551)
+++ kdeaccessibility/kttsd/players/alsaplayer/alsaplayer.cpp    (working copy)
@@ -406,7 +406,7 @@
     snd_pcm_info_alloca(&pcminfo);
     QStringList result;

-    result.append("default");
+    result.append( i18n("default"));
     for (;;) {
         err = snd_card_next(&card);
         if (err < 0 || card < 0) break;
Index: kdeaccessibility/kttsd/kcmkttsmgr/kcmkttsmgr.cpp
===================================================================
--- kdeaccessibility/kttsd/kcmkttsmgr/kcmkttsmgr.cpp    (revision 542551)
+++ kdeaccessibility/kttsd/kcmkttsmgr/kcmkttsmgr.cpp    (working copy)
@@ -210,7 +210,7 @@
         m_kttsmgrw->pcmLabel->setEnabled(true);
         m_kttsmgrw->pcmComboBox->setEnabled(true);
         QStringList pcmList = player->getPluginList("");
-        pcmList.append("custom");
+        pcmList.append( i18n("custom") );
         kdDebug() << "KCMKttsMgr::KCMKttsMgr: ALSA pcmList = " << pcmList << endl;
         m_kttsmgrw->pcmComboBox->clear();
         m_kttsmgrw->pcmComboBox->insertStringList(pcmList);
Comment 1 Gary Cramblitt 2006-05-23 23:20:41 UTC
> in the audio tab of kttsmgr there are untranslatable strings in the listbox
> alsa device.


These are ALSA PCM Names.  AFAIK, PCM Names are not translated, i.e., on a 
German desktop, if you look at the asoundrc files 
(eg. /usr/share/alsa/alsa.conf) you will see "default", not the German 
translation of "Default"?
Comment 2 Burkhard Lück 2006-05-24 17:26:17 UTC
Yes, the ALSA PCM Names in my /usr/share/alsa/alsa.conf are "default" and not the german translation of "Default".

But in a german language environment "custom" and "default" are visible strings, not translated, as listboxitems in the audio tab of the kttsmgr dialog. 
And any untranslated string on german desktop looks strange, doesn't it?
That's nothing a user will expect.

I know that my patch is nonsence, as makes a config item in kttsmgrrc language dependent, this seems to be strange to me. 
Comment 3 Stephan Johach 2006-05-24 18:48:04 UTC
I agree with Burkhard. As these two strings are generic names, they should be translable in the GUI and internally mapped to the actual device names.

On the other hand I have a device listed which is called "default:0 Intel ICH5". So the string "default" can appear in other entries too. I don't think there's an easy solution. But as I am not an alsa expert I have no clue about device naming conventions.

What about KDE 4? Will kttsd be ported to phonon? If so I expect these alsa devices to go away anyway.
Comment 4 Thomas Reitelbach 2006-05-24 21:30:38 UTC
Created attachment 16260 [details]
screenshot

Regarding the comment #1 from Gary:

Please see the attached screenshot. I guess the first and the last entry in the
listbox do not directly correspond to ALSA devices. The first one "default"
looks like a "link" to my default ALSA device (which real name is snd_card in
my asound.conf).
The last entry enables the checkbox next to the listbox and makes it possible
to set a custom ALSA device name.

IMO both, the first and the last entry in the list should be translatable. From
the code it looks like they are handled indepently from the others. At least
the entry "custom" should use i18n.
Comment 5 Thomas Reitelbach 2006-05-24 22:31:11 UTC
...and of course i meant the "textbox" next to the list, not a checkbox ;-) sorry for the confusion.
Comment 6 Gary Cramblitt 2006-05-25 22:43:12 UTC
> What about KDE 4? Will kttsd be ported to phonon? If so I expect these alsa
> devices to go away anyway.


Depends.  The Phonon devs tell me there won't be an ALSA backend in Phonon for 
playing simple .wav files (since there won't be a decoder).  That means that 
a "heaver" backend such as xine or GStreamer or NMM or whatever would have to 
be used.  It remains to be seen what latency that adds.  It is really 
important that speech starts playing ASAP and that when to told to shut up, 
stops ASAP.  I'm going to be adding a Phonon plugin soon, so we'll see what 
the latency is.  If latency is not a problem in Phonon, then I agree that 
KTTS should simply use Phonon and the other audio plugins can go away, 
including ALSA.

I don't think the "default" pcm name should be translated because this is a 
proper name -- a system "device" name.  Translating this would be akin to 
translating /dev/dsp.  The "custom" entry is another matter.  I'll probably 
fix this in KDE4.  Maybe I'll change to a checkbox or something.
Comment 7 Jeremy Whiting 2009-06-11 23:05:10 UTC
Actually, with kde 4.4 the whole audio tab will be going away, as kttsd is going to be just a wrapper around speech-dispatcher which uses alsa by default (and maybe can use gstreamer, I'd have to check).

Jeremy
Comment 8 Jeremy Whiting 2011-05-25 04:12:35 UTC
The audio tab is completely gone since kttsmgr (now Jovie) just wraps speech-dispatcher, which can use alsa, pulse, or some other audio output method.  I suppose once jovie gets some ui to configure speech-dispatcher itself this question might come back, but for now it's a non-issue.