Bug 127573 - Histogram spot not updated in mouse-toggle original/target mode with BW tool
Summary: Histogram spot not updated in mouse-toggle original/target mode with BW tool
Status: REPORTED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-BlackWhite (show other bugs)
Version: 0.9.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
: 150544 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-05-18 13:17 UTC by Daniel Bauer
Modified: 2023-05-02 16:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bauer 2006-05-18 13:17:01 UTC
Version:           0.9.0 svn (using KDE KDE 3.5.2)
Installed from:    SuSE RPMs
OS:                Linux

In digikam/filter/convert-to-b/w, when preview is set to the mode wehre mouse-over/mouse-out toggles between original and target view, clicking the red "hot spot" somewhere in the image does not update the position in the histogram (red line with value of the clicked position).

When changing the preview mode, the "hot spot" stays where I have clicked it, but the shown position in the histogram is still not updated. However clicking it again (in all other preview modes except the said one) will update it.
Comment 1 Andi Clemens 2008-09-01 14:01:29 UTC
This is true to all imageplugins I tested so far, it seems that the histogram and color information is only updated when your click in the target preview (for example use one of the split view modes). If used in "mouse over" preview mode, you also click onto the original image section, which doesn't seem to update the histogram.
I don't know if this is a feature or bug...

Gilles,

what about this one? Is the histogram and color information only updated when clicking on the target pane?

Andi
Comment 2 Andi Clemens 2008-09-01 14:03:16 UTC
*** Bug 150544 has been marked as a duplicate of this bug. ***
Comment 3 caulier.gilles 2008-09-01 14:10:14 UTC
Andi,

The histogram on right panel is the target image. So, the marker is only updated over histogram when you click on preview target image...

Updating histogram with original/target image is not implemented. We will review this feature when we will implement EditorToolPreview class.

Gilles
Comment 4 Andi Clemens 2008-09-01 14:19:11 UTC
All right...
Comment 5 Justin Zobel 2022-10-21 23:59:55 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 6 Daniel Bauer 2022-10-23 09:05:20 UTC
(In reply to Justin Zobel from comment #5)
> Thank you for reporting this bug in KDE software. As it has been a while
> since this issue was reported, can we please ask you to see if you can
> reproduce the issue with a recent software version?
> 
> If you can reproduce the issue, please change the status to "CONFIRMED" when
> replying. Thank you!

Oh, that's 16 years ago. Honestly, I don't remember :-)

There is no more "filter" menu. The only thing I find is "color -> black-and-white..." and if I chose to show the target preview there is no "hot spot" in the image at all, and clicking in the preview doesn't have any effect in the histogram shown under "Leuchtkraft".

Actually I don't use digikam's histogram functions since a long as they are not very responsive (there is a very notable delay between moving the line and the display of the result). I do things like that in Gimp...
Comment 7 Bug Janitor Service 2022-11-07 05:09:13 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 caulier.gilles 2023-05-02 16:49:29 UTC
Maik,

The color spot to histogram feature have been broken since a while when the canvas of editor have been port to model/view/controler (i think in version 4 or 5).

Few tools used this feature through the signal "spotPositionChangedFromTarget(Digikam::DColor,QPoint)" emitted from the image editor preview widget (connexion is commented in plugins as the signal do not exists for the moment).

illes@U22:/mnt/data/Devel/8.x/core$ grep "spotPositionChangedFromTarget" -R 
dplugins/editor/colors/whitebalance/whitebalancetool.cpp:    connect(d->previewWidget, SIGNAL(spotPositionChangedFromTarget(Digikam::DColor,QPoint)),
dplugins/editor/colors/adjustcurves/adjustcurvestool.cpp:    connect(d->previewWidget, SIGNAL(spotPositionChangedFromTarget(Digikam::DColor,QPoint)),
dplugins/editor/colors/adjustlevels/adjustlevelstool.cpp:    connect(d->previewWidget, SIGNAL(spotPositionChangedFromTarget(Digikam::DColor,QPoint)),
dplugins/editor/filters/colorfx/colorfxtool.cpp:    connect(d->previewWidget, SIGNAL(spotPositionChangedFromTarget(Digikam::DColor,QPoint)),
utilities/imageeditor/widgets/imageguidewidget.cpp:                Q_EMIT spotPositionChangedFromTarget(color, d->spot);
utilities/imageeditor/widgets/imageguidewidget.cpp:                    Q_EMIT spotPositionChangedFromTarget(color, QPoint(d->spot.x() - d->rect.width() / 2,
utilities/imageeditor/widgets/imageguidewidget.cpp:                    Q_EMIT spotPositionChangedFromTarget(color, d->spot);
utilities/imageeditor/widgets/imageguidewidget.cpp:                    Q_EMIT spotPositionChangedFromTarget(color, QPoint(d->spot.x(),
utilities/imageeditor/widgets/imageguidewidget.cpp:                    Q_EMIT spotPositionChangedFromTarget(color, d->spot);
utilities/imageeditor/widgets/imageguidewidget.h:    void spotPositionChangedFromTarget(const Digikam::DColor& color, const QPoint& position);
utilities/imageeditor/editor/editortool.cpp:        connect(d->view, SIGNAL(spotPositionChangedFromTarget(Digikam::DColor,QPoint)),
gilles@U22:/mnt/data/Devel/8.x/core$ 

Typically, a button were available in the plugin to capture preview point color and push the RGB value to the histogram to display a vertical bar. The goal is to visualize quickly if a region of image is over or under exposed.

The code activate the feature in the preview widget and to fire the signal is... missing as it never been ported.

Gilles
Gilles