Bug 126488 - KGhostView has incorrect .desktop files
Summary: KGhostView has incorrect .desktop files
Status: RESOLVED FIXED
Alias: None
Product: kghostview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Luís Pedro Coelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-29 21:40 UTC by Emanuele Tamponi
Modified: 2006-05-03 21:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for kghostview.desktop (removes KPart) (428 bytes, patch)
2006-04-29 21:42 UTC, Emanuele Tamponi
Details
kghostview_part.desktop file for the KPart (285 bytes, patch)
2006-04-29 21:43 UTC, Emanuele Tamponi
Details
Patch for Makefile.am (399 bytes, patch)
2006-04-29 21:45 UTC, Emanuele Tamponi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuele Tamponi 2006-04-29 21:40:12 UTC
Version:            (using KDE KDE 3.5.2)
Installed from:    Compiled From Sources
Compiler:          gcc version 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9)
OS:                Linux

Hello,
I noticed that kghostview.desktop is shared between the KPart and the standalone application, leading to inconsistences in Konqueror handling (KGhostview appears 2 times in "Open With" submenu, KGhostView is launched as default also if kpdf has been set as default by the user, etc).

I've already written the two .desktop files (kghostview.desktop for the standalone application and kghostview_part.desktop for the KPart) and made a patch for Makefile.am.

You should only put them in your svn, they are ready, I hope...

Good bye,
Emanuele T.
Comment 1 Emanuele Tamponi 2006-04-29 21:42:02 UTC
Created attachment 15849 [details]
Patch for kghostview.desktop (removes KPart)

This simply remove the KPart handling in kghostview.desktop

KPart will be handled by kghostview_part.desktop
Comment 2 Emanuele Tamponi 2006-04-29 21:43:11 UTC
Created attachment 15850 [details]
kghostview_part.desktop file for the KPart

This will handle the KPart of KGhostView
Comment 3 Emanuele Tamponi 2006-04-29 21:45:20 UTC
Created attachment 15851 [details]
Patch for Makefile.am

This is a patch for Makefile.am that adds kghostview_part.desktop to the
installed files.
Comment 4 Albert Astals Cid 2006-05-03 21:58:19 UTC
SVN commit 537052 by aacid:

Fix KGhostView .desktop files
BUGS: 126488


 M  +3 -0      Makefile.am  
 M  +0 -4      kghostview.desktop  
 A             kghostview_part.desktop  


--- branches/KDE/3.5/kdegraphics/kghostview/Makefile.am #537051:537052
@@ -52,6 +52,9 @@
 partdir = $(kde_datadir)/kghostview
 part_DATA = kgv_part.rc kghostviewui.rc
 
+partdesktopdir   = $(kde_servicesdir)
+partdesktop_DATA = kghostview_part.desktop
+
 messages: rc.cpp
 	$(XGETTEXT) *.cpp *.h -o $(podir)/kghostview.pot
 
--- branches/KDE/3.5/kdegraphics/kghostview/kghostview.desktop #537051:537052
@@ -79,8 +79,4 @@
 GenericName[zh_TW]=PS/PDF 檢視器
 GenericName[zu]=Umboniseli we PS/PDF
 Terminal=false
-ServiceTypes=KParts/ReadOnlyPart,Browser/View
-X-KDE-Library=libkghostviewpart
-X-KDE-StartupNotify=true
-X-DCOP-ServiceType=Multi
 Categories=Qt;KDE;Graphics;