Bug 126335 - Autoration of photos may confuse user because of changes made he is not aware of
Summary: Autoration of photos may confuse user because of changes made he is not aware of
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Import-PostProcessing (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-27 08:20 UTC by krienke
Modified: 2017-08-17 17:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description krienke 2006-04-27 08:20:30 UTC
Version:           0.90 SVN (using KDE KDE 3.5.2)
Installed from:    SuSE RPMs
OS:                Linux

Lately I copied a bunch of photos directly from my CF card into my digikam Folder. Then I used the imageeditor of digikam to walk through the photos. 

What happened was, that after scrolling from one photo to the next without having modified the photo in any way I was asked if the changes should be saved. I first thought digikam was going mad but then noticed that this only happened when the photo I had looked at was in protrait orientation and I had checked the option in digikams setup to do autorotation. Well thats what digikam did, but its somewhat confusing since digikam does not tell me that it changed the photo and then the user is suddenly asked if he wants to save his changes without himself having changed a thing.

I think some sort of notification would be helpful here to tell the user that the photo has been rotated.
Comment 1 caulier.gilles 2006-04-27 08:23:06 UTC
This problem have been fixed recently by Marcel normally. 
Are you used a fresh svn checkout ?

Gilles Caulier
Comment 2 krienke 2006-04-27 08:31:34 UTC
Am Donnerstag, 27. April 2006 08:23 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]

Its not the latest one perhaps my build is a week old. I'll get the latest 
version and check if this bug has gone then.

Thanks
Rainer
Comment 3 krienke 2006-04-28 13:34:55 UTC
I checked the latest version. It has been fixed but in a way I would not have expected because of the option "Rotate photo according to EXIF" in the digikam setup. 

At the moment the photos are left untouched and are only shown rotated. I would have expected that the photos are really beeing rotated when this option is selected so that I could also look at them with another tool not aware of EXIF infos. But this is not true at the moment. Perhaps still another option in the setup to say "physically rotate the photos and store them rotated" would be helpful to make things clearer.
Comment 4 Marcel Wiesweg 2006-04-28 21:39:32 UTC
For this you can use the Jpeglossless kipi plugin, there is an action "Rotate according to exif", or do it directly when importing from the camera dialog, which has the same code built in.
The image editor is pixel based and can principally not do Jpeg rotation in a lossless way.
Comment 5 krienke 2006-05-03 11:53:43 UTC
Am Freitag, 28. April 2006 21:39 schrieb Marcel Wiesweg:
[bugs.kde.org quoted mail]

Yes this is of course true and I already did use the kipi plugins. However at 
the moment its still confusing since the digikam setup option says "Rotate 
images and thumbnails according to exif tags info". This implies for me that 
my photos are really permanently rotated no matter when digikam does this.
So perhaps this option in the setup should be renamed to something like "show 
images rotated according to exif info"  or something like this. The problem 
is that in digikam you always see your photos rotated correctly but when you 
taken them unmodified somewhere else you suddenly are suprised that they are 
actually not rotated if you have a simple viewer that does not do exif based 
rotation for you.

Using the camera dialog is not an option for me, since for me it does not work 
(Bug: http://bugs.kde.org/show_bug.cgi?id=124952   ) .

Rainer
Comment 6 caulier.gilles 2006-05-19 11:54:26 UTC
SVN commit 542416 by cgilles:

digikam from trunk : fix setup message about exif-rotation actions witch can be confuse for users. The image is not transformed, and is only displayed rotated.
CCBUGS: 126335

 M  +1 -1      showfoto/setup/setupeditor.cpp  
 M  +2 -2      utilities/setup/setupmetadata.cpp  


--- trunk/extragear/graphics/digikam/showfoto/setup/setupeditor.cpp #542415:542416
@@ -108,7 +108,7 @@
     QVGroupBox *ExifGroupOptions = new QVGroupBox(i18n("EXIF Actions"), parent);
     
     d->exifRotateBox = new QCheckBox(ExifGroupOptions);
-    d->exifRotateBox->setText(i18n("&Rotate images/thumbs according to orientation tag"));
+    d->exifRotateBox->setText(i18n("Show images/thumbs &rotated according to orientation tag"));
   
     d->exifSetOrientationBox = new QCheckBox(ExifGroupOptions);
     d->exifSetOrientationBox->setText(i18n("Set orientation tag to normal after rotate/flip"));
--- trunk/extragear/graphics/digikam/utilities/setup/setupmetadata.cpp #542415:542416
@@ -89,8 +89,8 @@
     QGroupBox *ExifGroup = new QGroupBox(1, Qt::Horizontal, i18n("EXIF Actions"), parent);
   
     d->ExifRotateBox = new QCheckBox(ExifGroup);
-    d->ExifRotateBox->setText(i18n("&Rotate images/thumbs according to orientation tag"));
-  
+    d->ExifRotateBox->setText(i18n("Show images/thumbs &rotated according to orientation tag"));
+    
     d->ExifSetOrientationBox = new QCheckBox(ExifGroup);
     d->ExifSetOrientationBox->setText(i18n("Set orientation tag to normal after rotate/flip"));
     
Comment 7 caulier.gilles 2006-05-19 11:58:04 UTC
SVN commit 542421 by cgilles:

digikam from trunk : fix setup message about exif-rotation actions witch can be confuse for users. The image is not transformed, and is only displayed rotated.
BUG: 126335

 M  +1 -1      setupexif.cpp  


--- branches/stable/extragear/graphics/digikam/utilities/setup/setupexif.cpp #542420:542421
@@ -66,7 +66,7 @@
    layout->addWidget(iconSaveExifBox_);
 
    iconExifRotateBox_ = new QCheckBox(this);
-   iconExifRotateBox_->setText(i18n("&Rotate images and thumbnails according to EXIF tag"));
+   iconExifRotateBox_->setText(i18n("Show images/thumbs &rotated according to EXIF orientation tag"));
    layout->addWidget(iconExifRotateBox_);
 
    iconExifSetOrientationBox_ = new QCheckBox(this);