Bug 126085 - [PATCH] fix for wordwrap bug (disabled wordwrap in filled in comments prevents faxes being sent)
Summary: [PATCH] fix for wordwrap bug (disabled wordwrap in filled in comments prevent...
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kdeprint
Classification: Unmaintained
Component: kdeprintfax (show other bugs)
Version: unspecified
Platform: unspecified All
: NOR normal
Target Milestone: ---
Assignee: KDEPrint Devel Mailinglist
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-22 20:25 UTC by Ray Lischner
Modified: 2011-05-27 18:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Trivial patch to leave wordwrap enabled for the Comment box (593 bytes, patch)
2006-04-22 20:26 UTC, Ray Lischner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ray Lischner 2006-04-22 20:25:27 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

The Comment edit box has wordwrap disabled. This is wrong.

If the user enters a hard newline in the edit box, the newline is passed to the fax system program, which invariably barfs (technical term whose precise meaning varies with fax system; HylaFax, for example, reports "500 'JPARM COMMENTS "line 1': Syntax error, unmatched quote mark").

Thus, the user must not enter any explicit newline characters in the Comment box, and must instead rely on the fax program to wordwrap the text on the fax cover sheet.

With wordwrap disabled in the edit box, however, the user has difficulty typing because the text scrolls.

I see no reason to disable wordwrap. The patch removes the line of code that does this.
Comment 1 Ray Lischner 2006-04-22 20:26:23 UTC
Created attachment 15745 [details]
Trivial patch to leave wordwrap enabled for the Comment box
Comment 2 Kurt Pfeifle 2007-01-11 22:54:15 UTC
Though I don't understand the code, I'll set bug status as NEW (trusting the reporter's competence, since Cristian has already previously accepted and commited patches from him).

Can someone please check Ray's code and apply & test it?

(changed previous $summary: "wordwrap is disabled for Comments")
Comment 3 John Layt 2011-05-27 18:17:30 UTC
KDEPrint is obsolete, unmaintained and will never be revived.  Closing all open bugs.