Version: 1.4-beta3 (using KDE KDE 3.5.2) Installed from: Debian testing/unstable Packages Compiler: gcc version 4.0.3 (Debian 4.0.3-1) OS: Linux Installed 1.4-beta3 and found that the same bug that I submitted toward 1.3.8 (#125684) exists in the beta tree for 1.4 Within the "Cover Found" screen, the keyboard shortcuts for "New _Search" and "Next _Cover" conflict with the shortcuts for "_Save" and "_Cancel". Also, when the "Cover Found" screen appears, it does not have application modal (main amaroK menu retains modal until "Cover Found" screen is given focus).
*coughs* Got a bit overzealous. Keyboard shortcuts work correctly in 1.4-beta3, but modal focus is still wrong.
*** Bug 125684 has been marked as a duplicate of this bug. ***
Created attachment 15925 [details] Patch to fix the keyboard shortcuts for the New Search and Next Cover buttons This patch fixes the keyboard nav shortcuts on the Fetch Cover dialog. Please note that this should not be subject to the string freeze because the only change to the string is which letter is the hotkey. This along with the fact that each language picks its own shortcut key, no retranslation should be necessary. If that is not possible, perhaps we could create a en_US po file to translate "Next &Cover" to "&Next Cover" and "New &Search" to "Ne&w Search".
Some additional description: When the "Cover Found" dialog pops up, it does not have focus, but in my version (compiled from source) it is application modal. Before focus is granted, the buttons are as follows, "&Save", "New &Search..", "Next &Cover" and "&Cancel", after clicking, it becomes "&Save", "&New Search..", "N&ext Cover" and "&Cancel". Searching through the code didn't show those strings anywhere. Also, upon clicking "Next Cover" in whichever format, the modal dialog loses focus, probably because it's destroyed and then recreated.
Exists in yesterday's SVN also..
We don't normally accept patches which haven't been created properly. It's customary (sorry, mandatory) to not patch the translated files. (*.po)
SVN commit 553257 by seb: Don't set keyboard shortcuts for coverfetcher dialog to be conflicting. BUG: 125687 M +2 -2 coverfetcher.cpp M +4 -2 covermanager.cpp --- trunk/extragear/multimedia/amarok/src/coverfetcher.cpp #553256:553257 @@ -553,8 +553,8 @@ QLabel *labelName = new QLabel( this ); QHBox *buttons = new QHBox( this ); KPushButton *save = new KPushButton( KStdGuiItem::save(), buttons ); - KPushButton *newsearch = new KPushButton( i18n( "New &Search..." ), buttons, "NewSearch" ); - KPushButton *nextcover = new KPushButton( i18n( "Next &Cover" ), buttons, "NextCover" ); + KPushButton *newsearch = new KPushButton( i18n( "Ne&w Search..." ), buttons, "NewSearch" ); + KPushButton *nextcover = new KPushButton( i18n( "&Next Cover" ), buttons, "NextCover" ); KPushButton *cancel = new KPushButton( KStdGuiItem::cancel(), buttons ); labelPix ->setAlignment( Qt::AlignHCenter ); --- trunk/extragear/multimedia/amarok/src/covermanager.cpp #553256:553257 @@ -543,14 +543,16 @@ m_coverView->selectAll( false); QIconViewItem *item = m_coverView->firstItem(); - while ( item ) { + while ( item ) + { QIconViewItem *tmp = item->nextItem(); m_coverView->takeItem( item ); item = tmp; } m_coverView->setAutoArrange( false ); - for( QIconViewItem *item = m_coverItems.first(); item; item = m_coverItems.next() ) { + for( QIconViewItem *item = m_coverItems.first(); item; item = m_coverItems.next() ) + { CoverViewItem *coverItem = static_cast<CoverViewItem*>(item); if( coverItem->album().contains( m_filter, false ) || coverItem->artist().contains( m_filter, false ) ) m_coverView->insertItem( item, m_coverView->lastItem() );