Bug 125076 - konqueror can't display google video
Summary: konqueror can't display google video
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: nsplugins (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: George Staikos
URL:
Keywords:
: 135447 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-06 22:52 UTC by Giovanni Venturi
Modified: 2006-12-09 12:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Giovanni Venturi 2006-04-06 22:52:19 UTC
Version:           3.5.2 (using KDE 3.5.2, compiled sources)
Compiler:          gcc version 3.4.6
OS:                Linux (i686) release 2.6.16.1

If I go here, I just hear the sounds, but nothing is displayed:

http://video.google.com/videoplay?docid=1834474414005937031

With Firefox I get sound and video correctly.
Comment 1 Thiago Macieira 2006-04-10 01:02:01 UTC
How are we supposed to find out why the closed-source Flash plugin is failing to do what it's supposed to do?
Comment 2 Giovanni Venturi 2006-04-10 21:38:36 UTC
Well you are right. A closed application cannot be debugged, but with KDE 3.5.1 it worked.
Comment 3 Akos Polster 2006-04-10 22:34:20 UTC
Same problem with KDE 3.5.1-2.3 Red Hat. The same Flash plugin works fine with Firefox.
Comment 4 Sebastian Turzański 2006-07-19 14:51:33 UTC
You can compare how firefox manages this and it might help
Comment 5 r.downing 2006-08-02 00:08:54 UTC
FYI if you resize the konqueror window then the video starts playing but not all is displayed. Maximise does not help so one must drag the window border larger to show more of the video. It is very hard to get the playback controls to show up. It looks (pure hand-waving and speculation) like the plugin isn't being told its viewport size correctly.
Comment 6 P. Varet 2006-08-17 17:16:58 UTC
Bug confirmed here on KDE 3.5.4, compiled from sources.

To give more details about the symptoms: an empty grey area is displayed in lieu of the plug-in, but the sound plays correctly. The grey area reacts to right-click by displaying the Flash plug-in menu.

Resizing the window does indeed make the picture appear.

Apparently, what the site does is, it inserts the <embed> tag dynamically with a Javascript function called as an onload event. It seems that Konqueror doesn't properly tell the Flash plug-in about its geometry in this case.

Interestingly, the same thing happens when you load a Flash file directly into Konqueror.
Comment 7 Nick Warne 2006-09-15 22:10:40 UTC
Messing about with this, using Epiptany, it loses the flash toolbar.  Resizing Epipthany though restores the flash 'window' correctly and all works as should.

Resizing Konq does make the video appear, but to me it is then only a part of it - usually the top and bottom/sides are cut off.

So, looking around a bit:

http://bugs.kde.org/show_bug.cgi?id=117603

Was this patch applied?

Also what I don't understand why it did work in 3.5.1, and now doesn't and nobody seems to know (or care) why?

Nick
Comment 8 Nick Warne 2006-09-15 22:30:38 UTC
Well, here's a thing.  I can play google videos on 3.5.4!!! with a bit of messing

First, I use Konq with no menu bar, and limited toolbars at full screen all the time...

So, visit the link (I picked a nice one :-) ) and then hit F9 to get history bar... then hit F9 to toggle history off, and google video is working fine with toolbar and all.

http://video.google.co.uk/videoplay?docid=8271874173492401222

Nick
Comment 9 Jeffrey Parke 2006-09-28 22:10:39 UTC
Error: http://video.google.co.uk/jslib/misc.vbs?v=851738: SyntaxError: Parse error at line 2
Error: http://video.google.co.uk/jslib/misc.vbs?v=851738: SyntaxError: Parse error at line 2

that is what konqueror says about it
Comment 10 Maksim Orlovich 2006-09-29 00:48:04 UTC
SVN commit 589919 by orlovich:

- Make sure we always size the plugin:
    - Fixes google videos showing up.
    - Fixes acroread in background tab.
 
- Make sure to notify the plugin directly of size changes:
    - Fixes resizing of google videos
    - Makes sizing of acroread more reliable
    
BUG:117603
BUG:125076
BUG:118038

... And potentially a couple others, will double-check.


 M  +5 -0      nspluginloader.cpp  
 M  +1 -0      nspluginloader.h  
 M  +1 -5      viewer/nsplugin.cpp  
 M  +0 -1      viewer/nsplugin.h  


--- branches/KDE/3.5/kdebase/nsplugins/nspluginloader.cpp #589918:589919
@@ -120,6 +120,11 @@
   kdDebug() << "NSPluginInstance(client)::resizeEvent" << endl;
 }
 
+void NSPluginInstance::showEvent(QShowEvent *event)
+{
+  EMBEDCLASS::showEvent(event);
+  resizePlugin(width(), height());
+}
 
 /*******************************************************************************/
 
--- branches/KDE/3.5/kdebase/nsplugins/nspluginloader.h #589918:589919
@@ -56,6 +56,7 @@
 
 protected:
     void resizeEvent(QResizeEvent *event);
+    void showEvent  (QShowEvent *);
     void windowChanged(WId w);
     class NSPluginLoader *_loader;
     bool shown;
--- branches/KDE/3.5/kdebase/nsplugins/viewer/nsplugin.cpp #589918:589919
@@ -588,7 +588,6 @@
    : DCOPObject(), QObject( parent, name ) 
 {
     Q_UNUSED(embed);
-   _firstResize = true;
    _visible = false;
    _npp = privateData;
    _npp->ndata = this;
@@ -988,10 +987,7 @@
 
    resizeWidgets(XtWindow(_form), _width, _height);
 
-   if (_firstResize) {
-      _firstResize = false;
-      setWindow();
-   }
+   setWindow();
 
    kdDebug(1431) << "<- NSPluginInstance::resizePlugin" << endl;
 }
--- branches/KDE/3.5/kdebase/nsplugins/viewer/nsplugin.h #589918:589919
@@ -220,7 +220,6 @@
 
   bool _destroyed;
   bool _visible;
-  bool _firstResize;
   void addTempFile(KTempFile *tmpFile);
   QPtrList<KTempFile> _tempFiles;
   NSPluginCallbackIface_stub *_callback;
Comment 11 Nick Warne 2006-09-29 18:41:24 UTC
Thanks Maksim, works perfectly :-)

Nick
Comment 12 Tommi Tervo 2006-10-11 12:14:57 UTC
*** Bug 135447 has been marked as a duplicate of this bug. ***
Comment 13 Petrov Dmithriy 2006-12-08 21:50:16 UTC
konq 3.5.5 from Debian sid. Google video is not displayed. Other flash (like tauceramic.com) displayed correctly. Double presssing F9 does not help :(
Comment 14 Giovanni Venturi 2006-12-09 11:58:00 UTC
konq 3.5.5 from Debian sid is not a KDE original code. Ask Debian how many patches added... On Konqueror 3.5.5 compiled from original source code works perfectly.
Comment 15 Sebastian Turzański 2006-12-09 12:02:52 UTC
works ok with 3.5.5 shipped with OpenSuse repos