Bug 124060 - use same menu mnemonic for Filter as Krita (and Photoshop, and ...)
Summary: use same menu mnemonic for Filter as Krita (and Photoshop, and ...)
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-22 11:14 UTC by Alan Horkan
Modified: 2017-08-07 21:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Horkan 2006-03-22 11:14:24 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources

The Filter menu in the digikam image editor uses the mnemonic _l in Fi_lter whereas Krita (and Photoshop) use the mnemonic Filte_r.  

Usability guidelines often advise against using mnemonics with the narrow letters such as i, l, or j if at all possible.
Comment 1 caulier.gilles 2006-03-22 13:18:33 UTC
I agree to homogenise menu shortcut (mnemonic) like krita and photoshop done.

Please make an more advanced comparison betwen digikam image editor and krita and photoshop menu entries (outside Filter menu), and we will trying to fix this problem (very easy to fix in implementation)

Thanks in advance

Gilles Caulier
Comment 2 Alan Horkan 2006-03-22 14:10:14 UTC
> I agree to homogenise menu shortcut (mnemonic) like krita and photoshop done. 

Thanks.  I would have provided a patch but SVN wasn't quite working as expected (probably something wrong with my local copy, couldn't create a diff).  I just wanted to get a quick report in today, I do not think I've time to do a more thorough review/reorganisation of the menus (maybe in the future I'll try and make a list of recommendations).  

There is alreadyanother existing report which makes suggestions on changing the menu structure.  http://bugs.kde.org/show_bug.cgi?id=89365

Comment 3 caulier.gilles 2006-07-25 16:06:43 UTC
SVN commit 566138 by cgilles:

digikam from trunk: use same menu mnemonic for Filter as Krita and Photoshop
BUG: 124060

 M  +2 -2      blurfx/digikamimageplugin_blurfx_ui.rc  
 M  +2 -2      charcoal/digikamimageplugin_charcoal_ui.rc  
 M  +2 -2      distortionfx/digikamimageplugin_distortionfx_ui.rc  
 M  +2 -2      emboss/digikamimageplugin_emboss_ui.rc  
 M  +2 -2      filmgrain/digikamimageplugin_filmgrain_ui.rc  
 M  +2 -2      infrared/digikamimageplugin_infrared_ui.rc  
 M  +2 -2      oilpaint/digikamimageplugin_oilpaint_ui.rc  
 M  +2 -2      raindrop/digikamimageplugin_raindrop_ui.rc  
 M  +2 -2      solarize/digikamimageplugin_solarize_ui.rc  


--- trunk/extragear/graphics/digikamimageplugins/blurfx/digikamimageplugin_blurfx_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_blurfx" >
+<kpartgui version="3" name="digikamimageplugin_blurfx" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_blurfx" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/charcoal/digikamimageplugin_charcoal_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_charcoal" >
+<kpartgui version="3" name="digikamimageplugin_charcoal" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_charcoal" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/distortionfx/digikamimageplugin_distortionfx_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_distortionfx" >
+<kpartgui version="3" name="digikamimageplugin_distortionfx" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_distortionfx" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/emboss/digikamimageplugin_emboss_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_emboss" >
+<kpartgui version="3" name="digikamimageplugin_emboss" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_emboss" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/filmgrain/digikamimageplugin_filmgrain_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_filmgrain" >
+<kpartgui version="3" name="digikamimageplugin_filmgrain" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_filmgrain" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/infrared/digikamimageplugin_infrared_ui.rc #566137:566138
@@ -1,9 +1,9 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_infrared" >
+<kpartgui version="3" name="digikamimageplugin_infrared" >
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_infrared" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/oilpaint/digikamimageplugin_oilpaint_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_oilpaint" >
+<kpartgui version="3" name="digikamimageplugin_oilpaint" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_oilpaint" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/raindrop/digikamimageplugin_raindrop_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_raindrop" >
+<kpartgui version="3" name="digikamimageplugin_raindrop" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_raindrop" /> 
   </Menu>
 
--- trunk/extragear/graphics/digikamimageplugins/solarize/digikamimageplugin_solarize_ui.rc #566137:566138
@@ -1,10 +1,10 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="2" name="digikamimageplugin_solarize" >
+<kpartgui version="3" name="digikamimageplugin_solarize" >
 
  <MenuBar>
 
   <Menu name="Filters" >
-   <text>Fi&amp;lters</text>
+   <text>Filte&amp;rs</text>
    <Action name="imageplugin_solarize" /> 
   </Menu>
 
Comment 4 Alan Horkan 2006-07-25 17:20:02 UTC
Thanks