Bug 123683 - Kompare should support Unicode / UTF-8 text files
Summary: Kompare should support Unicode / UTF-8 text files
Status: RESOLVED DUPLICATE of bug 112729
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: 3.4.1
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-15 21:18 UTC by Hrishikesh Mehendale (हृषीकेश मेहेंदळे)
Modified: 2007-12-19 09:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Do not ignore encoding settings (877 bytes, patch)
2006-10-18 15:53 UTC, Richard Kralovic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hrishikesh Mehendale (हृषीकेश मेहेंदळे) 2006-03-15 21:18:57 UTC
Version:           3.4.1 (using KDE 3.4.3, Kubuntu Package 4:3.4.3-0ubuntu2 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.10-5-386

At (my) present version, Kompare shows the ascii characters for UTF-8 text. It would be useful to have Kompare displaying Unicode (optionally, e.g. Settings->File Is UTF-8). This will be especially useful for translation folks, and also later when people need to diff UTF-coded text.
Comment 1 Florin 2006-05-29 10:51:41 UTC
Completely agree. I'd like to see unicode support for kompare, it would make it a very useful tool
Comment 2 rgpublic 2006-09-29 16:31:10 UTC
*** This bug has been confirmed by popular vote. ***
Comment 3 Richard Kralovic 2006-10-18 15:51:53 UTC
It seems that Kompare supports utf-8, if the locales are set appropriately (setting only LC_CTYPE is not enough, but LANG, LC_ALL and LC_CTYPE should work). But there is another problem: It is possible to specify UTF8 even if it is not locale default, but this setting is ignored. The following patch corrects the problem, at least for me (but I am not sure if it does not introduce other problems :-) )
Comment 4 Richard Kralovic 2006-10-18 15:53:02 UTC
Created attachment 18174 [details]
Do not ignore encoding settings
Comment 5 Bruno Friedmann 2006-11-24 10:59:09 UTC
Hi Richard, is there any chance to see your patch included in the main branch ?
I'm working with the kde 3.5.5 release 45.1 made by the openSuSe factory for the 10.1 distribution.

And for sure not supporting utf-8 in kompare is really something annoyng for us like all other people not working with ascii art :-)

Thanks to help on this issue
Comment 6 2006-12-11 20:07:19 UTC
Isnt this going to be fixed in branch_3.5?
Comment 7 2006-12-11 21:44:30 UTC
I did applyied this patch (in attachement id=18174) but when running kompare i continued seeing that doesnt support utf-8 when using the default encoding that in this case (Mandriva 2007) is utf-8.

Kompare only supports utf-8 if in encoding option is selected utf-8 and this doesnt make much sense since the default distro encoding is utf-8 so kompare should support utf-8 when using default encoding and wich isnt the case.

Also this report should never be set as a wish since this is a bug.
Comment 8 Bruno Friedmann 2006-12-12 11:21:58 UTC
It's not resolve in 3.5.5 
I'm using the lastest build from OpenSuse factory.

When I kompare 2 text files which are encoded in utf-8 on my OpenSuse 10.1 box which have also utf-8. Kompare doesn't care about what we give to it as encode (utf-8, iso8859 ... ) The render view is ugly with false encoding for caracters.

I agree on the fact that's not a wish, that should be a bug, and it certainly time to fix it before the move to qt4 and kde4x series.

 
Comment 9 Serhiy Kachanuk 2007-02-13 12:26:48 UTC
Additionally, there is no way to set encoding when only viewing existing patch file in kompare, for example with this command: 
#kfmclient exec some.patch
Comment 10 Antti Kaihola 2007-04-07 08:36:53 UTC
Is this maybe related to (or duplicate of) bugs 95054 and 112729?
Comment 11 Jan Zimmerschied 2007-06-01 16:55:17 UTC
Yes, the supplied patch (id=18174) works great!
Comment 12 George Goldberg 2007-12-19 09:21:44 UTC
This is fixed in trunk for KDE4 and the KDE 3.5 branch.
Comment 13 Kevin Kofler 2007-12-19 09:23:19 UTC
Reopening to mark as duplicate...
Comment 14 Kevin Kofler 2007-12-19 09:23:44 UTC

*** This bug has been marked as a duplicate of 112729 ***