Bug 123055 - qscintilla support does not get added to libsmokeqt when --enable-qscintilla=yes is specified
Summary: qscintilla support does not get added to libsmokeqt when --enable-qscintilla=...
Status: RESOLVED FIXED
Alias: None
Product: bindings
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: FreeBSD Ports FreeBSD
: NOR normal
Target Milestone: ---
Assignee: kde-bindings
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-04 05:54 UTC by Jason E. Hale
Modified: 2014-07-29 16:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale 2006-03-04 05:54:45 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    FreeBSD Ports
Compiler:          GCC 3.4.4 
OS:                FreeBSD

When libsmokeqt is compiled with --enable-qscintilla=yes set, the configure option does not get recognized because $withval is used in configure.in instead of $enableval.  The following is a patch for kdebindings-3.5.1/smoke/qt/configure.in.in:

--- 2006-03-03-libsmokeqt-configure.in.in.diff starts here ---
--- configure.in.in.orig	Sat Sep 10 04:16:39 2005
+++ configure.in.in	Fri Mar  3 23:46:27 2006
@@ -33,7 +33,7 @@
 AC_ARG_ENABLE(
    qscintilla,
    [  --enable-qscintilla@<:@=yes|no@:>@   Smoke: build Smoke with QScintilla extention for qt @<:@default:no@:>@],
-   [ qtextscintilla="$withval" ],
+   [ qtextscintilla="$enableval" ],
    [ qtextscintilla="no" ]
 )
 AC_SUBST(qtextscintilla)
--- 2006-03-03-libsmokeqt-configure.in.in.diff ends here ---
Comment 1 Caleb Tennis 2006-03-04 14:56:55 UTC
why not just use --with-qscintilla ?
Comment 2 Jason E. Hale 2006-03-04 16:54:37 UTC
Caleb, that would be a workaround and does not fix the problem.  If it is supposed to be --with-qscintilla, then it should be changed to that so anyone looking at the configure script and all of the available configure arguments won't be misled by trying --enable-qscintilla only to find qcscintilla support was not compiled.  The fact is I had to spend time trying to figure out what was going on and this is a subtle item that is easy to miss.
Comment 3 Richard Dale 2006-03-09 22:13:33 UTC
SVN commit 517076 by rdale:

* Applied fix from Jason Hale to make the enable qscintilla build option
  work

CCBUGS: 123055



 M  +1 -1      configure.in.in  


--- branches/KDE/3.5/kdebindings/smoke/qt/configure.in.in #517075:517076
@@ -33,7 +33,7 @@
 AC_ARG_ENABLE(
    qscintilla,
    [  --enable-qscintilla@<:@=yes|no@:>@   Smoke: build Smoke with QScintilla extention for qt @<:@default:no@:>@],
-   [ qtextscintilla="$withval" ],
+   [ qtextscintilla="$enableval" ],
    [ qtextscintilla="no" ]
 )
 AC_SUBST(qtextscintilla)
Comment 4 Raphael Kubo da Costa 2014-07-29 16:59:05 UTC
Fixed many years ago, and valid only for 3.x. Closing.